Skip to content

fix: eliminate provider leak and migrate to shared logger/error packages #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaximusHaximus merged 7 commits into from
Mar 30, 2026

refactor(env): extract truthyStrings/falsyStrings in BooleanOrBoolean…

d245f0d
Select commit
Loading
Failed to load commit list.
Merged

fix: eliminate provider leak and migrate to shared logger/error packages #73

refactor(env): extract truthyStrings/falsyStrings in BooleanOrBoolean…
d245f0d
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 30, 2026 in 31s

Quality Gate failed

Failed conditions
1 Security Hotspot
6.1% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 235 in src/services/v1ProofGenerationServices.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'buildError' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_proof-generation-api&issues=AZ02caxwPU4l3pg_E6zh&open=AZ02caxwPU4l3pg_E6zh&pullRequest=73

Check warning on line 282 in src/scripts/memory-report.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `.at(…)` over `[….length - index]`. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_proof-generation-api&issues=AZ02J_Qbmfd6IM4TUlFQ&open=AZ02J_Qbmfd6IM4TUlFQ&pullRequest=73

Check warning on line 314 in src/services/v1ProofGenerationServices.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'checkpointError' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_proof-generation-api&issues=AZ0245RriB6M1OIqIsHc&open=AZ0245RriB6M1OIqIsHc&pullRequest=73

Check warning on line 319 in src/scripts/memory-report.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer top-level await over using a promise chain. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_proof-generation-api&issues=AZ02J_Qbmfd6IM4TUlFR&open=AZ02J_Qbmfd6IM4TUlFR&pullRequest=73

Check warning on line 48 in src/env.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`booleanStrings` should be a `Set`, and use `booleanStrings.has()` to check existence or non-existence. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_proof-generation-api&issues=AZ0_LOGXkWhB4ytK1V9_&open=AZ0_LOGXkWhB4ytK1V9_&pullRequest=73

Check warning on line 33 in src/scripts/memory-report.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseInt` over `parseInt`. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_proof-generation-api&issues=AZ02J_Qbmfd6IM4TUlFI&open=AZ02J_Qbmfd6IM4TUlFI&pullRequest=73

Check warning on line 9 in src/logger.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use `export…from` to re-export `Logger`. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_proof-generation-api&issues=AZ02gv1riB6M1OIqHEbb&open=AZ02gv1riB6M1OIqHEbb&pullRequest=73

Check warning on line 246 in src/scripts/memory-report.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_proof-generation-api&issues=AZ02J_Qbmfd6IM4TUlFO&open=AZ02J_Qbmfd6IM4TUlFO&pullRequest=73

Check warning on line 215 in src/services/v1ProofGenerationServices.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'checkpointError' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_proof-generation-api&issues=AZ02caxwPU4l3pg_E6zg&open=AZ02caxwPU4l3pg_E6zg&pullRequest=73

Check warning on line 34 in src/scripts/memory-report.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseInt` over `parseInt`. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_proof-generation-api&issues=AZ02J_Qbmfd6IM4TUlFJ&open=AZ02J_Qbmfd6IM4TUlFJ&pullRequest=73

Check warning on line 39 in src/scripts/memory-report.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseInt` over `parseInt`. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_proof-generation-api&issues=AZ02J_Qbmfd6IM4TUlFK&open=AZ02J_Qbmfd6IM4TUlFK&pullRequest=73

Check warning on line 327 in src/services/v1ProofGenerationServices.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'buildError' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_proof-generation-api&issues=AZ02caxwPU4l3pg_E6zj&open=AZ02caxwPU4l3pg_E6zj&pullRequest=73

Check warning on line 260 in src/services/v1ProofGenerationServices.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'error' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_proof-generation-api&issues=AZ02caxwPU4l3pg_E6zi&open=AZ02caxwPU4l3pg_E6zi&pullRequest=73

Check warning on line 57 in src/scripts/memory-report.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_proof-generation-api&issues=AZ02J_Qbmfd6IM4TUlFM&open=AZ02J_Qbmfd6IM4TUlFM&pullRequest=73

Check warning on line 163 in src/services/v1ProofGenerationServices.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'error' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_proof-generation-api&issues=AZ02caxwPU4l3pg_E6zf&open=AZ02caxwPU4l3pg_E6zf&pullRequest=73

Check warning on line 53 in src/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'err' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_proof-generation-api&issues=AZ02toCPU7rlc86SOss_&open=AZ02toCPU7rlc86SOss_&pullRequest=73

Check warning on line 282 in src/scripts/memory-report.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_proof-generation-api&issues=AZ02J_Qbmfd6IM4TUlFP&open=AZ02J_Qbmfd6IM4TUlFP&pullRequest=73

Check warning on line 112 in src/services/v1ProofGenerationServices.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'error' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_proof-generation-api&issues=AZ02caxwPU4l3pg_E6ze&open=AZ02caxwPU4l3pg_E6ze&pullRequest=73

Check warning on line 40 in src/scripts/memory-report.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseInt` over `parseInt`. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_proof-generation-api&issues=AZ02J_Qbmfd6IM4TUlFL&open=AZ02J_Qbmfd6IM4TUlFL&pullRequest=73

Check warning on line 42 in src/maticClient.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected non-Promise value in a boolean conditional. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_proof-generation-api&issues=AZ02J_Nvmfd6IM4TUlFH&open=AZ02J_Nvmfd6IM4TUlFH&pullRequest=73

Check warning on line 345 in src/services/v1ProofGenerationServices.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'error' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_proof-generation-api&issues=AZ02caxwPU4l3pg_E6zk&open=AZ02caxwPU4l3pg_E6zk&pullRequest=73
View more details on SonarQubeCloud