Conversation
🧞 Codegenie Review✅ No credible findings. CoverageReviewed 13/66 hunks.
🙋 Needs Human Attention
Stats
✅ No FindingsNo credible findings were found. Everything looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
@earendil-works/pi-aifrom 0.83.0 to 0.84.2 and adapts to its new OAuth API, plus routine dependency updates.Dependency updates
@earendil-works/pi-ai: 0.83.0 → 0.84.2 (newly pulls in@earendil-works/pi-telemetry)smol-toml: 1.7.1 → 1.8.0web-tree-sitter: 0.26.11 → 0.26.12@types/node: 26.1.2 → 26.2.0tsx: 4.23.4 → 4.23.12Code changes (pi-ai 0.84 API)
src/llm/pi-runner.ts: OAuth token refresh now receives the requestAbortSignal.GetOAuthApiKey,resolveModelAuth, andgetOAuthApiKeyFromProviderthread the signal through tooauthAuth.refresh(credential, signal), so token refreshes can be cancelled when the request is aborted.src/provider/provider-services.ts:commandLogincreates anAbortControllerfor the login interaction, passes its signal tooauthAuth.login(...), and aborts it in thefinallyblock when the flow ends.phase4-llm.test.tsasserts the request signal is propagated to the OAuth refresh callback;phase4-skills-provider.test.tsuses the renamedProviderAuthInteractiontype and asserts the login signal is aborted after login completes.Verification
pnpm vitest run tests/phase4-llm.test.ts tests/phase4-skills-provider.test.ts— 154 tests passed