From ddf28971fb60d988627b42fa47a2663623fb3655 Mon Sep 17 00:00:00 2001 From: AB Date: Fri, 18 Sep 2026 08:45:31 +0200 Subject: [PATCH 1/5] Reworks structure --- demos/pom.xml | 19 + .../testcontainers-selenium-demo}/pom.xml | 25 +- .../main/java/software/xdev/Application.java | 0 pom.xml | 54 ++- src/pom.xml | 269 ++++++++++++ src/skip-publish.marker | 0 src/testcontainers-selenium/pom.xml | 133 ++++++ .../browser/BrowserWebDriverContainer.java | 0 ...CapabilitiesBrowserWebDriverContainer.java | 0 .../GenericContainerImageNameAccessor.java | 0 .../containers/browser/SeleniumUtils.java | 0 .../browser/SeleniumVersionDetector.java | 0 .../recorder/RecordingContainer.java | 0 .../recorder/SeleniumRecordingContainer.java | 0 .../selenium/SimpleContainerTest.java | 0 ...GenericContainerImageNameAccessorTest.java | 0 testcontainers-selenium/pom.xml | 384 ------------------ 17 files changed, 468 insertions(+), 416 deletions(-) create mode 100644 demos/pom.xml rename {testcontainers-selenium-demo => demos/testcontainers-selenium-demo}/pom.xml (81%) rename {testcontainers-selenium-demo => demos/testcontainers-selenium-demo}/src/main/java/software/xdev/Application.java (100%) create mode 100644 src/pom.xml create mode 100644 src/skip-publish.marker create mode 100644 src/testcontainers-selenium/pom.xml rename {testcontainers-selenium => src/testcontainers-selenium}/src/main/java/software/xdev/testcontainers/selenium/containers/browser/BrowserWebDriverContainer.java (100%) rename {testcontainers-selenium => src/testcontainers-selenium}/src/main/java/software/xdev/testcontainers/selenium/containers/browser/CapabilitiesBrowserWebDriverContainer.java (100%) rename {testcontainers-selenium => src/testcontainers-selenium}/src/main/java/software/xdev/testcontainers/selenium/containers/browser/GenericContainerImageNameAccessor.java (100%) rename {testcontainers-selenium => src/testcontainers-selenium}/src/main/java/software/xdev/testcontainers/selenium/containers/browser/SeleniumUtils.java (100%) rename {testcontainers-selenium => src/testcontainers-selenium}/src/main/java/software/xdev/testcontainers/selenium/containers/browser/SeleniumVersionDetector.java (100%) rename {testcontainers-selenium => src/testcontainers-selenium}/src/main/java/software/xdev/testcontainers/selenium/containers/recorder/RecordingContainer.java (100%) rename {testcontainers-selenium => src/testcontainers-selenium}/src/main/java/software/xdev/testcontainers/selenium/containers/recorder/SeleniumRecordingContainer.java (100%) rename {testcontainers-selenium => src/testcontainers-selenium}/src/test/java/software/xdev/testcontainers/selenium/SimpleContainerTest.java (100%) rename {testcontainers-selenium => src/testcontainers-selenium}/src/test/java/software/xdev/testcontainers/selenium/containers/browser/GenericContainerImageNameAccessorTest.java (100%) delete mode 100644 testcontainers-selenium/pom.xml diff --git a/demos/pom.xml b/demos/pom.xml new file mode 100644 index 00000000..f204a45e --- /dev/null +++ b/demos/pom.xml @@ -0,0 +1,19 @@ + + + 4.0.0 + + + software.xdev + root + 2.1.2-SNAPSHOT + + + demos + pom + + + testcontainers-selenium-demo + + diff --git a/testcontainers-selenium-demo/pom.xml b/demos/testcontainers-selenium-demo/pom.xml similarity index 81% rename from testcontainers-selenium-demo/pom.xml rename to demos/testcontainers-selenium-demo/pom.xml index a8199b8e..33b00ed1 100644 --- a/testcontainers-selenium-demo/pom.xml +++ b/demos/testcontainers-selenium-demo/pom.xml @@ -6,26 +6,14 @@ software.xdev - testcontainers-selenium-root + demos 2.1.2-SNAPSHOT testcontainers-selenium-demo - 2.1.2-SNAPSHOT jar - - XDEV Software - https://xdev.software - - - 17 - ${javaVersion} - - UTF-8 - UTF-8 - software.xdev.Application @@ -105,17 +93,6 @@ ${project.artifactId} - - org.apache.maven.plugins - maven-compiler-plugin - 3.16.0 - - ${maven.compiler.release} - - -proc:none - - - org.apache.maven.plugins maven-assembly-plugin diff --git a/testcontainers-selenium-demo/src/main/java/software/xdev/Application.java b/demos/testcontainers-selenium-demo/src/main/java/software/xdev/Application.java similarity index 100% rename from testcontainers-selenium-demo/src/main/java/software/xdev/Application.java rename to demos/testcontainers-selenium-demo/src/main/java/software/xdev/Application.java diff --git a/pom.xml b/pom.xml index 3e51e0d9..e4ddddcd 100644 --- a/pom.xml +++ b/pom.xml @@ -5,25 +5,45 @@ 4.0.0 software.xdev - testcontainers-selenium-root + root 2.1.2-SNAPSHOT pom - - XDEV Software - https://xdev.software - - - testcontainers-selenium - testcontainers-selenium-demo + src + demos + 17 + ${javaVersion} + UTF-8 UTF-8 + https://github.com/xdev-software/testcontainers-selenium + + + https://github.com/xdev-software/testcontainers-selenium + scm:git:https://github.com/xdev-software/testcontainers-selenium.git + + + 2024 + + + XDEV Software + https://xdev.software + + + + + XDEV Software + XDEV Software + https://xdev.software + + + Apache-2.0 @@ -32,6 +52,24 @@ + + + + + org.apache.maven.plugins + maven-compiler-plugin + 3.16.0 + + ${maven.compiler.release} + + -proc:none + + + + + + + checkstyle diff --git a/src/pom.xml b/src/pom.xml new file mode 100644 index 00000000..eb317565 --- /dev/null +++ b/src/pom.xml @@ -0,0 +1,269 @@ + + + 4.0.0 + + + software.xdev + root + 2.1.2-SNAPSHOT + + + src + pom + + + testcontainers-selenium + + + + + + + org.apache.maven.plugins + maven-site-plugin + 4.0.0-M16 + + + org.apache.maven.plugins + maven-project-info-reports-plugin + 3.9.0 + + + + org.apache.maven.plugins + maven-javadoc-plugin + 3.12.0 + + + org.apache.maven.plugins + maven-source-plugin + 3.4.0 + + + + org.apache.maven.plugins + maven-install-plugin + 3.1.4 + + + org.apache.maven.plugins + maven-deploy-plugin + 3.1.4 + + + + org.codehaus.mojo + flatten-maven-plugin + 1.8.0 + + + org.apache.maven.plugins + maven-gpg-plugin + 3.2.8 + + + org.sonatype.central + central-publishing-maven-plugin + 0.11.0 + + + + + + com.mycila + license-maven-plugin + 5.1.2 + + + ${project.organization.url} + + + +
com/mycila/maven/plugin/license/templates/APACHE-2.txt
+ + src/main/java/** + src/test/java/** + +
+
+
+ + + first + + format + + process-sources + + +
+ + + org.apache.maven.plugins + maven-javadoc-plugin + + + attach-javadocs + package + + jar + + + + + true + none + + + + org.apache.maven.plugins + maven-source-plugin + + + attach-sources + package + + jar-no-fork + + + + +
+
+ + + do-not-publish-this + + + skip-publish.marker + + + + + + org.codehaus.mojo + flatten-maven-plugin + false + + true + + + + + org.apache.maven.plugins + maven-javadoc-plugin + false + + true + + + + org.apache.maven.plugins + maven-source-plugin + false + + true + + + + + maven-install-plugin + false + + true + + + + maven-deploy-plugin + false + + true + + + + + org.apache.maven.plugins + maven-gpg-plugin + false + + true + + + + org.sonatype.central + central-publishing-maven-plugin + false + + true + + + + + + + publish + + true + + + + + org.codehaus.mojo + flatten-maven-plugin + + ossrh + + + + flatten + process-resources + + flatten + + + + + + org.apache.maven.plugins + maven-gpg-plugin + + + sign-artifacts + verify + + sign + + + + + + --pinentry-mode + loopback + + + + + + + + + + publish-sonatype-central-portal + + + + org.sonatype.central + central-publishing-maven-plugin + true + + sonatype-central-portal + true + + + + + + +
diff --git a/src/skip-publish.marker b/src/skip-publish.marker new file mode 100644 index 00000000..e69de29b diff --git a/src/testcontainers-selenium/pom.xml b/src/testcontainers-selenium/pom.xml new file mode 100644 index 00000000..cc6d45ca --- /dev/null +++ b/src/testcontainers-selenium/pom.xml @@ -0,0 +1,133 @@ + + + 4.0.0 + + + software.xdev + src + 2.1.2-SNAPSHOT + + + testcontainers-selenium + jar + + testcontainers-selenium + testcontainers-selenium + + + + true + + 4.49.0 + + + + + org.testcontainers + testcontainers + 2.0.5 + + + + + org.slf4j + slf4j-api + 2.0.19 + + + + + org.seleniumhq.selenium + selenium-api + ${selenium.version} + provided + + + + + org.junit.jupiter + junit-jupiter + 6.1.3 + test + + + org.slf4j + slf4j-simple + 2.0.19 + test + + + org.seleniumhq.selenium + selenium-remote-driver + ${selenium.version} + test + + + + io.opentelemetry + * + + + + org.seleniumhq.selenium + selenium-manager + + + + + org.seleniumhq.selenium + selenium-support + ${selenium.version} + test + + + org.seleniumhq.selenium + selenium-firefox-driver + ${selenium.version} + test + + + + org.seleniumhq.selenium + selenium-manager + + + + + org.seleniumhq.selenium + selenium-chrome-driver + ${selenium.version} + test + + + + org.seleniumhq.selenium + selenium-manager + + + + + + + + + org.apache.maven.plugins + maven-surefire-plugin + 3.6.0 + + ${skipTests} + + + + + + + run-integration-tests + + false + + + + diff --git a/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/BrowserWebDriverContainer.java b/src/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/BrowserWebDriverContainer.java similarity index 100% rename from testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/BrowserWebDriverContainer.java rename to src/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/BrowserWebDriverContainer.java diff --git a/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/CapabilitiesBrowserWebDriverContainer.java b/src/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/CapabilitiesBrowserWebDriverContainer.java similarity index 100% rename from testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/CapabilitiesBrowserWebDriverContainer.java rename to src/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/CapabilitiesBrowserWebDriverContainer.java diff --git a/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/GenericContainerImageNameAccessor.java b/src/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/GenericContainerImageNameAccessor.java similarity index 100% rename from testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/GenericContainerImageNameAccessor.java rename to src/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/GenericContainerImageNameAccessor.java diff --git a/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/SeleniumUtils.java b/src/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/SeleniumUtils.java similarity index 100% rename from testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/SeleniumUtils.java rename to src/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/SeleniumUtils.java diff --git a/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/SeleniumVersionDetector.java b/src/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/SeleniumVersionDetector.java similarity index 100% rename from testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/SeleniumVersionDetector.java rename to src/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/SeleniumVersionDetector.java diff --git a/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/recorder/RecordingContainer.java b/src/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/recorder/RecordingContainer.java similarity index 100% rename from testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/recorder/RecordingContainer.java rename to src/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/recorder/RecordingContainer.java diff --git a/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/recorder/SeleniumRecordingContainer.java b/src/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/recorder/SeleniumRecordingContainer.java similarity index 100% rename from testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/recorder/SeleniumRecordingContainer.java rename to src/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/recorder/SeleniumRecordingContainer.java diff --git a/testcontainers-selenium/src/test/java/software/xdev/testcontainers/selenium/SimpleContainerTest.java b/src/testcontainers-selenium/src/test/java/software/xdev/testcontainers/selenium/SimpleContainerTest.java similarity index 100% rename from testcontainers-selenium/src/test/java/software/xdev/testcontainers/selenium/SimpleContainerTest.java rename to src/testcontainers-selenium/src/test/java/software/xdev/testcontainers/selenium/SimpleContainerTest.java diff --git a/testcontainers-selenium/src/test/java/software/xdev/testcontainers/selenium/containers/browser/GenericContainerImageNameAccessorTest.java b/src/testcontainers-selenium/src/test/java/software/xdev/testcontainers/selenium/containers/browser/GenericContainerImageNameAccessorTest.java similarity index 100% rename from testcontainers-selenium/src/test/java/software/xdev/testcontainers/selenium/containers/browser/GenericContainerImageNameAccessorTest.java rename to src/testcontainers-selenium/src/test/java/software/xdev/testcontainers/selenium/containers/browser/GenericContainerImageNameAccessorTest.java diff --git a/testcontainers-selenium/pom.xml b/testcontainers-selenium/pom.xml deleted file mode 100644 index 7ea7580a..00000000 --- a/testcontainers-selenium/pom.xml +++ /dev/null @@ -1,384 +0,0 @@ - - - 4.0.0 - - software.xdev - testcontainers-selenium - 2.1.2-SNAPSHOT - jar - - testcontainers-selenium - testcontainers-selenium - https://github.com/xdev-software/testcontainers-selenium - - - https://github.com/xdev-software/testcontainers-selenium - scm:git:https://github.com/xdev-software/testcontainers-selenium.git - - - 2024 - - - XDEV Software - https://xdev.software - - - - - XDEV Software - XDEV Software - https://xdev.software - - - - - - Apache-2.0 - https://www.apache.org/licenses/LICENSE-2.0.txt - repo - - - - - 17 - ${javaVersion} - - UTF-8 - UTF-8 - - - true - - - - - org.testcontainers - testcontainers - 2.0.5 - - - - - org.slf4j - slf4j-api - 2.0.19 - - - - - org.seleniumhq.selenium - selenium-api - 4.49.0 - provided - - - - - org.junit.jupiter - junit-jupiter - 6.1.3 - test - - - org.slf4j - slf4j-simple - 2.0.19 - test - - - org.seleniumhq.selenium - selenium-remote-driver - 4.49.0 - test - - - - io.opentelemetry - * - - - - org.seleniumhq.selenium - selenium-manager - - - - - org.seleniumhq.selenium - selenium-support - 4.49.0 - test - - - org.seleniumhq.selenium - selenium-firefox-driver - 4.49.0 - test - - - - org.seleniumhq.selenium - selenium-manager - - - - - org.seleniumhq.selenium - selenium-chrome-driver - 4.49.0 - test - - - - org.seleniumhq.selenium - selenium-manager - - - - - - - - - - org.apache.maven.plugins - maven-site-plugin - 4.0.0-M16 - - - org.apache.maven.plugins - maven-project-info-reports-plugin - 3.9.0 - - - - - - com.mycila - license-maven-plugin - 5.1.2 - - - ${project.organization.url} - - - -
com/mycila/maven/plugin/license/templates/APACHE-2.txt
- - src/main/java/** - src/test/java/** - -
-
-
- - - first - - format - - process-sources - - -
- - - org.apache.maven.plugins - maven-compiler-plugin - 3.16.0 - - ${maven.compiler.release} - - -proc:none - - - - - org.apache.maven.plugins - maven-javadoc-plugin - 3.12.0 - - - attach-javadocs - package - - jar - - - - - true - none - - - - org.apache.maven.plugins - maven-source-plugin - 3.4.0 - - - attach-sources - package - - jar-no-fork - - - - - - - org.apache.maven.plugins - maven-surefire-plugin - 3.6.0 - - ${skipTests} - - -
-
- - - run-integration-tests - - false - - - - publish - - - - org.codehaus.mojo - flatten-maven-plugin - 1.8.0 - - ossrh - - - - flatten - process-resources - - flatten - - - - - - org.apache.maven.plugins - maven-gpg-plugin - 3.2.8 - - - sign-artifacts - verify - - sign - - - - - - --pinentry-mode - loopback - - - - - - - - - - publish-sonatype-central-portal - - - - org.sonatype.central - central-publishing-maven-plugin - 0.11.0 - true - - sonatype-central-portal - true - - - - - - - checkstyle - - - - org.apache.maven.plugins - maven-checkstyle-plugin - 3.6.0 - - - com.puppycrawl.tools - checkstyle - 14.1.0 - - - - ../.config/checkstyle/checkstyle.xml - true - - - - - check - - - - - - - - - pmd - - - - org.apache.maven.plugins - maven-pmd-plugin - 3.28.0 - - true - true - true - - ../.config/pmd/java/ruleset.xml - - - - - net.sourceforge.pmd - pmd-core - 7.27.0 - - - net.sourceforge.pmd - pmd-java - 7.27.0 - - - - - - - - - - org.apache.maven.plugins - maven-jxr-plugin - 3.6.0 - - - - - -
From 3dd81be621a1f222d5391927d431c75a7c39f83c Mon Sep 17 00:00:00 2001 From: AB Date: Fri, 18 Sep 2026 08:52:32 +0200 Subject: [PATCH 2/5] Fine tune pom, start editing workflows --- .github/workflows/check-build.yml | 4 ++-- .github/workflows/test-deploy.yml | 11 ++++------- pom.xml | 3 +++ src/pom.xml | 7 +++++++ 4 files changed, 16 insertions(+), 9 deletions(-) diff --git a/.github/workflows/check-build.yml b/.github/workflows/check-build.yml index d815c747..1f90f491 100644 --- a/.github/workflows/check-build.yml +++ b/.github/workflows/check-build.yml @@ -160,10 +160,10 @@ jobs: ${{ runner.os }}-pmd- - name: Run PMD - run: ./mvnw -B test pmd:aggregate-pmd-no-fork pmd:check -P pmd -DskipTests -T2C + run: ./mvnw -B test pmd:aggregate-pmd-no-fork pmd:check -P pmd -T2C - name: Run CPD (Copy Paste Detector) - run: ./mvnw -B pmd:aggregate-cpd pmd:cpd-check -P pmd -DskipTests -T2C + run: ./mvnw -B pmd:aggregate-cpd pmd:cpd-check -P pmd -T2C - name: Upload report if: ${{ !cancelled() }} diff --git a/.github/workflows/test-deploy.yml b/.github/workflows/test-deploy.yml index 9f665060..e4dae054 100644 --- a/.github/workflows/test-deploy.yml +++ b/.github/workflows/test-deploy.yml @@ -3,9 +3,6 @@ name: Test Deployment on: workflow_dispatch: -env: - PRIMARY_MAVEN_MODULE: ${{ github.event.repository.name }} - jobs: publish-maven: runs-on: ubuntu-latest @@ -24,8 +21,8 @@ jobs: gpg-private-key: ${{ secrets.MAVEN_GPG_PRIVATE_KEY }} # Only import once - name: Publish to GitHub Packages Central - run: ../mvnw -B deploy -P publish -DskipTests -DaltDeploymentRepository=github-central::https://maven.pkg.github.com/xdev-software/central - working-directory: ${{ env.PRIMARY_MAVEN_MODULE }} + run: ../mvnw -B deploy -P publish -DaltDeploymentRepository=github-central::https://maven.pkg.github.com/xdev-software/central + working-directory: src env: PACKAGES_CENTRAL_TOKEN: ${{ secrets.PACKAGES_CENTRAL_TOKEN }} MAVEN_GPG_PASSPHRASE: ${{ secrets.MAVEN_GPG_PASSPHRASE }} @@ -41,8 +38,8 @@ jobs: gpg-passphrase: MAVEN_GPG_PASSPHRASE - name: Publish to Central Portal - run: ../mvnw -B deploy -P publish,publish-sonatype-central-portal -DskipTests - working-directory: ${{ env.PRIMARY_MAVEN_MODULE }} + run: ../mvnw -B deploy -P publish,publish-sonatype-central-portal + working-directory: src env: MAVEN_CENTRAL_USERNAME: ${{ secrets.SONATYPE_MAVEN_CENTRAL_PORTAL_USERNAME }} MAVEN_CENTRAL_TOKEN: ${{ secrets.SONATYPE_MAVEN_CENTRAL_PORTAL_TOKEN }} diff --git a/pom.xml b/pom.xml index e4ddddcd..68d0687d 100644 --- a/pom.xml +++ b/pom.xml @@ -103,6 +103,9 @@
pmd + + true + diff --git a/src/pom.xml b/src/pom.xml index eb317565..1afb65ef 100644 --- a/src/pom.xml +++ b/src/pom.xml @@ -202,10 +202,17 @@ + + pmd + + true + + publish true + true From 02ca26826b30f257d7f17c52b5c24a798f653ac3 Mon Sep 17 00:00:00 2001 From: AB Date: Fri, 18 Sep 2026 09:16:13 +0200 Subject: [PATCH 3/5] Fix lanucher --- .run/Run Demo.run.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/.run/Run Demo.run.xml b/.run/Run Demo.run.xml index c7be02be..fabbaed4 100644 --- a/.run/Run Demo.run.xml +++ b/.run/Run Demo.run.xml @@ -2,7 +2,6 @@ + + site + + true + true + +