compiler warnings for unused variables in wolfssl/wolfcrypt/src/random.c

[escherstair]

Under some combinations of compiler defines, variables seed and seedSz here

wolfssl/wolfcrypt/src/random.c

Lines 1722 to 1723 in 145a4fa

	word32 seedSz = SEED_SZ + SEED_BLOCK_SZ;
	WC_DECLARE_VAR(seed, byte, MAX_SEED_SZ, rng->heap);

could be defined but not used.

I'm not 100% sure but this can be when CUSTOM_RAND_GENERATE_BLOCK is defined and so this path is taken

wolfssl/wolfcrypt/src/random.c

Lines 1850 to 1852 in 145a4fa

	#ifdef CUSTOM_RAND_GENERATE_BLOCK
	ret = 0; /* success */
	#else

I found this warning while testing https://github.com/danielinux/m33mu with its default configs

[kareem-wolfssl]

Hi @escherstair,

Please confirm if this patch works for you:

diff --git a/wolfcrypt/src/random.c b/wolfcrypt/src/random.c
index 4631734d7..1984c0a5c 100644
--- a/wolfcrypt/src/random.c
+++ b/wolfcrypt/src/random.c
@@ -1715,7 +1715,7 @@ static int _InitRng(WC_RNG* rng, byte* nonce, word32 nonceSz,
                     void* heap, int devId)
 {
     int ret = 0;
-#ifdef HAVE_HASHDRBG
+#if defined(HAVE_HASHDRBG) && !defined(CUSTOM_RAND_GENERATE_BLOCK)
 #if !defined(HAVE_FIPS) && defined(WOLFSSL_RNG_USE_FULL_SEED)
     word32 seedSz = SEED_SZ;
 #else

[escherstair]

Hi @kareem-wolfssl
I confirm that your patch works in my case.
No warning anymore.

Thanks