Streamline various places that construct PHP arrays

This is only about code style and doesn't change anything. The main
benefit is that the array is one unit, there are much less confusing
square brackets, and no variable name needs to be repeated.

Change-Id: Ibfcdbbcf8dafdef7887f795b91d5fa96dc3a6342

Author: thiemowmde

src/Diff/ItemDiffer.php

@@ -74,14 +74,12 @@ public function diffItems( Item $from, Item $to ): ItemDiff {
 	}
 
 	private function toDiffArray( Item $item ): array {
-		$array = [];
-
-		$array['aliases'] = $item->getAliasGroups()->toTextArray();
-		$array['label'] = $item->getLabels()->toTextArray();
-		$array['description'] = $item->getDescriptions()->toTextArray();
-		$array['links'] = $this->getSiteLinksInDiffFormat( $item->getSiteLinkList() );
-
-		return $array;
+		return [
+			'aliases' => $item->getAliasGroups()->toTextArray(),
+			'label' => $item->getLabels()->toTextArray(),
+			'description' => $item->getDescriptions()->toTextArray(),
+			'links' => $this->getSiteLinksInDiffFormat( $item->getSiteLinkList() ),
+		];
 	}
 
 	private function getSiteLinksInDiffFormat( SiteLinkList $siteLinks ): array {

src/Diff/PropertyDiffer.php

@@ -88,14 +88,12 @@ private function diffPropertyArrays( array $from, array $to ) {
 	 *
 	 * @return array[]
 	 */
-	private function toDiffArray( Property $property ) {
-		$array = [];
-
-		$array['aliases'] = $property->getAliasGroups()->toTextArray();
-		$array['label'] = $property->getLabels()->toTextArray();
-		$array['description'] = $property->getDescriptions()->toTextArray();
-
-		return $array;
+	private function toDiffArray( Property $property ): array {
+		return [
+			'aliases' => $property->getAliasGroups()->toTextArray(),
+			'label' => $property->getLabels()->toTextArray(),
+			'description' => $property->getDescriptions()->toTextArray(),
+		];
 	}
 
 	/**