From 816c5889c0b2398bc5c3245db1de5917bdf95102 Mon Sep 17 00:00:00 2001 From: Steven Searcy Date: Tue, 17 Nov 2026 19:57:00 -0600 Subject: [PATCH] fix(batch): raise a clear error for unsupported property types --- test/collection/test_batch.py | 15 +++++++++++++-- weaviate/collections/batch/grpc_batch.py | 7 ++++--- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/test/collection/test_batch.py b/test/collection/test_batch.py index 79053710e..5cbf6c2ed 100644 --- a/test/collection/test_batch.py +++ b/test/collection/test_batch.py @@ -1,9 +1,10 @@ import uuid +from decimal import Decimal import pytest from weaviate.collections.batch.base import _RateLimitedBatching -from weaviate.collections.batch.grpc_batch import _validate_props +from weaviate.collections.batch.grpc_batch import _serialize_primitive, _validate_props from weaviate.collections.classes.batch import ( MAX_STORED_RESULTS, BatchObject, @@ -13,7 +14,7 @@ ErrorObject, ErrorReference, ) -from weaviate.exceptions import WeaviateInsertInvalidPropertyError +from weaviate.exceptions import WeaviateInsertInvalidPropertyError, WeaviateInvalidInputError def _error_object(index: int) -> ErrorObject: @@ -141,3 +142,13 @@ def test_validate_props_raises_for_top_level_vector() -> None: def test_validate_props_raises_for_nested_vector() -> None: with pytest.raises(WeaviateInsertInvalidPropertyError): _validate_props({"vector": [0.1, 0.2]}, nested=True) + + +@pytest.mark.parametrize("value", [Decimal("9.99"), [1.5, Decimal("2.5")], object()]) +def test_serialize_primitive_raises_for_unsupported_type(value) -> None: + with pytest.raises(WeaviateInvalidInputError, match="Cannot serialize value of type"): + _serialize_primitive(value) + + +def test_serialize_primitive_keeps_tuples_working() -> None: + assert _serialize_primitive((1, "a", None)) == [1, "a", None] diff --git a/weaviate/collections/batch/grpc_batch.py b/weaviate/collections/batch/grpc_batch.py index db20528a6..13fffad9a 100644 --- a/weaviate/collections/batch/grpc_batch.py +++ b/weaviate/collections/batch/grpc_batch.py @@ -374,7 +374,8 @@ def _serialize_primitive(value: Any) -> Any: return str(value) if isinstance(value, datetime.datetime): return _datetime_to_string(value) - if isinstance(value, list): + if isinstance(value, (list, tuple)): return [_serialize_primitive(val) for val in value] - - return value + if value is None or isinstance(value, (str, bool, int, float, dict)): + return value + raise WeaviateInvalidInputError(f"Cannot serialize value of type {type(value)} to Weaviate.")