From 4ebf4f4ea0ab4956db5289c7e744596ef0730ba1 Mon Sep 17 00:00:00 2001 From: Joe Isaacs Date: Thu, 2 Apr 2026 16:32:21 +0100 Subject: [PATCH 1/2] wip Signed-off-by: Joe Isaacs --- .github/workflows/bench-pr.yml | 18 ++++++++++++++---- .github/workflows/bench.yml | 22 ++++++++++++++++++---- 2 files changed, 32 insertions(+), 8 deletions(-) diff --git a/.github/workflows/bench-pr.yml b/.github/workflows/bench-pr.yml index 1fab5eb28bc..fff559e24c2 100644 --- a/.github/workflows/bench-pr.yml +++ b/.github/workflows/bench-pr.yml @@ -31,8 +31,18 @@ jobs: - id: random-access-bench name: Random Access build_args: "--features lance" - - id: compress-bench - name: Compression + - id: compress-bench-1 + name: Compression (1/3) + bin: compress-bench + extra_args: "--datasets '^(taxi|Arade|Bimbo|CMSprovider|Euro2016)$'" + - id: compress-bench-2 + name: Compression (2/3) + bin: compress-bench + extra_args: "--datasets '^(Food|HashTags|TPC-H)'" + - id: compress-bench-other + name: Compression (other) + bin: compress-bench + extra_args: "--datasets '^(?!taxi$|Arade$|Bimbo$|CMSprovider$|Euro2016$|Food$|HashTags$|TPC-H)'" steps: - uses: runs-on/action@v2 if: github.event.pull_request.head.repo.fork == false @@ -60,7 +70,7 @@ jobs: env: RUSTFLAGS: "-C target-cpu=native -C force-frame-pointers=yes" run: | - cargo build --package ${{ matrix.benchmark.id }} --profile release_debug ${{ matrix.benchmark.build_args }} + cargo build --package ${{ matrix.benchmark.bin || matrix.benchmark.id }} --profile release_debug ${{ matrix.benchmark.build_args }} - name: Setup Polar Signals if: github.event.pull_request.head.repo.fork == false @@ -77,7 +87,7 @@ jobs: env: RUST_BACKTRACE: full run: | - bash scripts/bench-taskset.sh target/release_debug/${{ matrix.benchmark.id }} -d gh-json -o results.json + bash scripts/bench-taskset.sh target/release_debug/${{ matrix.benchmark.bin || matrix.benchmark.id }} ${{ matrix.benchmark.formats && format('--formats {0}', matrix.benchmark.formats) || '' }} ${{ matrix.benchmark.extra_args }} -d gh-json -o results.json - name: Setup AWS CLI if: github.event.pull_request.head.repo.fork == false diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml index ebeb429849b..85f47b85519 100644 --- a/.github/workflows/bench.yml +++ b/.github/workflows/bench.yml @@ -44,10 +44,24 @@ jobs: name: Random Access build_args: "--features lance" formats: "parquet,lance,vortex" - - id: compress-bench - name: Compression + - id: compress-bench-1 + name: Compression (1/3) + bin: compress-bench build_args: "--features lance" formats: "parquet,lance,vortex" + extra_args: "--datasets '^(taxi|Arade|Bimbo|CMSprovider|Euro2016)$'" + - id: compress-bench-2 + name: Compression (2/3) + bin: compress-bench + build_args: "--features lance" + formats: "parquet,lance,vortex" + extra_args: "--datasets '^(Food|HashTags|TPC-H)'" + - id: compress-bench-other + name: Compression (other) + bin: compress-bench + build_args: "--features lance" + formats: "parquet,lance,vortex" + extra_args: "--datasets '^(?!taxi$|Arade$|Bimbo$|CMSprovider$|Euro2016$|Food$|HashTags$|TPC-H)'" steps: - uses: runs-on/action@v2 if: github.repository == 'vortex-data/vortex' @@ -73,7 +87,7 @@ jobs: env: RUSTFLAGS: "-C target-cpu=native -C force-frame-pointers=yes" run: | - cargo build --bin ${{ matrix.benchmark.id }} --profile release_debug ${{ matrix.benchmark.build_args }} + cargo build --bin ${{ matrix.benchmark.bin || matrix.benchmark.id }} --profile release_debug ${{ matrix.benchmark.build_args }} - name: Setup Polar Signals uses: polarsignals/gh-actions-ps-profiling@v0.8.1 @@ -89,7 +103,7 @@ jobs: env: RUST_BACKTRACE: full run: | - bash scripts/bench-taskset.sh target/release_debug/${{ matrix.benchmark.id }} --formats ${{ matrix.benchmark.formats }} -d gh-json -o results.json + bash scripts/bench-taskset.sh target/release_debug/${{ matrix.benchmark.bin || matrix.benchmark.id }} --formats ${{ matrix.benchmark.formats }} ${{ matrix.benchmark.extra_args }} -d gh-json -o results.json - name: Setup AWS CLI uses: aws-actions/configure-aws-credentials@v6 From 6d84c8d10d4cca7221b93b000dd15368975dfcee Mon Sep 17 00:00:00 2001 From: Joe Isaacs Date: Thu, 2 Apr 2026 16:52:22 +0100 Subject: [PATCH 2/2] wip Signed-off-by: Joe Isaacs --- .github/workflows/bench-pr.yml | 4 ++-- .github/workflows/bench.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/bench-pr.yml b/.github/workflows/bench-pr.yml index fff559e24c2..5310bd750fb 100644 --- a/.github/workflows/bench-pr.yml +++ b/.github/workflows/bench-pr.yml @@ -39,8 +39,8 @@ jobs: name: Compression (2/3) bin: compress-bench extra_args: "--datasets '^(Food|HashTags|TPC-H)'" - - id: compress-bench-other - name: Compression (other) + - id: compress-bench-3 + name: Compression (3/3) bin: compress-bench extra_args: "--datasets '^(?!taxi$|Arade$|Bimbo$|CMSprovider$|Euro2016$|Food$|HashTags$|TPC-H)'" steps: diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml index 85f47b85519..6d98d883af0 100644 --- a/.github/workflows/bench.yml +++ b/.github/workflows/bench.yml @@ -56,8 +56,8 @@ jobs: build_args: "--features lance" formats: "parquet,lance,vortex" extra_args: "--datasets '^(Food|HashTags|TPC-H)'" - - id: compress-bench-other - name: Compression (other) + - id: compress-bench-3 + name: Compression (3/3) bin: compress-bench build_args: "--features lance" formats: "parquet,lance,vortex"