fix(e2e): fake-llamacpp test hooks no longer reach the main process via require()

The whole e2e suite's llama.cpp-backed specs (8 of them) were failing in
CI with "ReferenceError: require is not defined" -- confirmed real by
reproducing locally with a headless Electron launch (no Xvfb needed to
repro, though CI uses xvfb-run for the real suite). Playwright's
ElectronApplication.evaluate() runs its callback in a bare V8 context
with no `require` anywhere in scope, including via indirect eval -- so
fake-llamacpp.ts's approach of re-require()-ing llamacpp-manager.ts's
compiled output from outside the process, to reach its test-only
setNextChatTurn/getChatRequestCount hooks, no longer works at all.

Fixed by having llamacpp-manager.ts expose those hooks directly on
globalThis, gated behind the exact same MODELFORGE_E2E_FAKE_LLAMACPP
check that already gates the fake module swap itself -- a no-op in
every real launch, same as before. fake-llamacpp.ts now just reads the
global instead of require()-ing anything.

Verified locally: all 25 e2e specs pass (temporarily launched Electron
with --headless=new instead of relying on Xvfb, which isn't installable
in this sandbox without root -- reverted that diagnostic tweak before
committing). app's own 1018-test suite and frontend's 101-test suite
both still pass after the llamacpp-manager.ts change.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Author: voidstackloop

app/src/llamacpp-manager.ts

@@ -121,6 +121,25 @@ export function __getFakeLlamaCppLastContextSizeForTests(): number | "auto" | nu
     return fakeState.lastContextSize;
 }
 
+// e2e/fixtures/fake-llamacpp.ts drives these test hooks from OUTSIDE this
+// process via Playwright's ElectronApplication.evaluate() — that callback
+// runs in a bare V8 execution context with no `require` in scope (Electron/
+// Playwright stopped exposing one; re-require()-ing this compiled file from
+// there throws "require is not defined"), so the hooks are exposed as a
+// global instead. Node's module cache still guarantees this is the exact
+// module instance chat-dispatch.ts already loaded — only *how* the outside
+// test process reaches it changed, not the "same instance" guarantee.
+// Gated the same as the fake module swap itself: absent in every real
+// launch, so this is a complete no-op outside an e2e run.
+if (process.env[FAKE_MODULE_ENV_VAR] === "1") {
+    (globalThis as unknown as { __modelforgeFakeLlamaCppTestHooks?: unknown }).__modelforgeFakeLlamaCppTestHooks = {
+        __setFakeLlamaCppNextChatTurnForTests,
+        __getFakeLlamaCppChatRequestCountForTests,
+        __getFakeLlamaCppContextCreationCountForTests,
+        __getFakeLlamaCppLastContextSizeForTests,
+    };
+}
+
 function sleep(ms: number): Promise<void> {
     return new Promise((resolve) => setTimeout(resolve, ms));
 }

e2e/fixtures/fake-llamacpp.ts

@@ -1,4 +1,3 @@
-import * as path from "node:path";
 import type { ElectronApplication } from "@playwright/test";
 
 // llama.cpp runs in-process (node-llama-cpp, no spawned server, no HTTP
@@ -9,14 +8,11 @@ import type { ElectronApplication } from "@playwright/test";
 // process's environment (see that file's own comment on why this is safe —
 // nothing in a real launch ever sets that variable). This fixture's job is
 // just wiring: setting the env var at launch (via LaunchOptions.env), and
-// controlling the fake's next response from the Playwright test process by
-// re-requiring the same compiled module inside the already-running main
-// process via ElectronApplication.evaluate() — Node's require cache
-// guarantees that resolves to the exact same module instance
-// chat-dispatch.ts already loaded, not a second copy.
-
-const APP_DIR = path.resolve(__dirname, "../../app");
-const LLAMACPP_MANAGER_JS = path.join(APP_DIR, "dist", "llamacpp-manager.js");
+// controlling the fake's next response from the Playwright test process via
+// ElectronApplication.evaluate() reading a global llamacpp-manager.ts
+// exposes for exactly this purpose (that callback runs in a bare V8 context
+// with no `require` in scope, so re-require()-ing the compiled module from
+// there — this fixture's old approach — no longer works).
 
 /** Environment for launchApp({ env: FAKE_LLAMACPP_ENV }) to activate the fake
  * module. Combine with settings like `{ preferredRuntime: "llamacpp" }` /
@@ -41,20 +37,14 @@ export interface FakeLlamaCppController {
 export function controlFakeLlamaCpp(app: ElectronApplication): FakeLlamaCppController {
     return {
         async setNextChatTurn(turn: FakeLlamaCppChatTurn): Promise<void> {
-            await app.evaluate(
-                (_electron, args: { managerPath: string; turn: FakeLlamaCppChatTurn }) => {
-                    const manager = require(args.managerPath);
-                    manager.__setFakeLlamaCppNextChatTurnForTests(args.turn);
-                },
-                { managerPath: LLAMACPP_MANAGER_JS, turn }
-            );
+            await app.evaluate((_electron, nextTurn: FakeLlamaCppChatTurn) => {
+                (globalThis as unknown as { __modelforgeFakeLlamaCppTestHooks: { __setFakeLlamaCppNextChatTurnForTests(t: FakeLlamaCppChatTurn): void } }).__modelforgeFakeLlamaCppTestHooks.__setFakeLlamaCppNextChatTurnForTests(nextTurn);
+            }, turn);
         },
         async getChatRequestCount(): Promise<number> {
-            return app.evaluate((_electron, managerPath: string) => {
-                // eslint-disable-next-line @typescript-eslint/no-var-requires
-                const manager = require(managerPath);
-                return manager.__getFakeLlamaCppChatRequestCountForTests();
-            }, LLAMACPP_MANAGER_JS);
+            return app.evaluate(() => {
+                return (globalThis as unknown as { __modelforgeFakeLlamaCppTestHooks: { __getFakeLlamaCppChatRequestCountForTests(): number } }).__modelforgeFakeLlamaCppTestHooks.__getFakeLlamaCppChatRequestCountForTests();
+            });
         },
     };
 }