From 8d3816db96f1af9e9bb30edb05e25b25b104523a Mon Sep 17 00:00:00 2001 From: masklinn Date: Wed, 4 Nov 2026 10:56:57 +0100 Subject: [PATCH] Fix collector workflow If a workflow is skipped, github considers it successful rather than unsuccessful, this is what caused #294 to automerge despite errors which had to be fixed in #295. By forcing the workflow to run then checking the the requirements were successful it should actually do what it's supposed to... Fixes #327 Reported-By: Lucas Sotomayor --- .github/workflows/ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4ff0542..a3570a1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -174,7 +174,8 @@ jobs: results: name: "CI Results" needs: ["checks", "test"] + if: always() runs-on: ubuntu-latest permissions: {} steps: - - run: exit 0 + - run: test "${{ needs.checks.result }}" = "success" && test "${{ needs.test.result }}" = "success"