fix: isObject should return false for functions#2684
Open
chatman-media wants to merge 1 commit into
Open
Conversation
The `isObject` function incorrectly returned `true` for function values because it checked `typeof value === 'function'` in addition to `typeof value === 'object'`. The README documentation explicitly states that functions should return false, but the implementation contradicted this. Fixes typestack#2515
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The
isObject/@IsObject()validator incorrectly accepts function values as valid objects.The README documentation is explicit (emphasis mine):
However, the implementation in
src/decorator/typechecker/IsObject.tsincludestypeof value === 'function'in the condition:This causes
isObject(() => 'x')to returntrue, which contradicts the documented behavior.Closes #2515
Root cause
The
|| typeof value === 'function'branch was included in the check, presumably to mirror a generic "non-primitive" guard. Since functions are not plain data objects, the docs correctly exclude them — the implementation just didn't follow through.Fix
Remove the
typeof value === 'function'branch:Test evidence
Two function values (
() => 'function'and a named function expression) were added to theinvalidValuesarray in theIsObjecttest suite. Before the fix, 2 tests failed; after the fix, all 5IsObjecttests pass and the full suite (806 tests) continues to pass.