From 582a2777e5316f07f6770860b577a52ce77ee1ba Mon Sep 17 00:00:00 2001 From: Tofik Hasanov Date: Fri, 19 Jun 2026 11:33:56 -0400 Subject: [PATCH] fix(integration-platform): surface setup instructions for non-custom auth types The connect UI only received setupInstructions when auth.type === 'custom', so basic/api_key integrations (e.g. HiBob, Supabase) fell back to the generic "You'll need your X credentials" placeholder even though detailed instructions exist in their manifest authConfig. Surface setupInstructions for any credential-entry auth type via an 'in' check; oauth2 stays excluded since its setupInstructions are admin app-creation steps, not customer connect steps. Co-Authored-By: Claude Opus 4.8 (1M context) --- .../controllers/connections.controller.ts | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/apps/api/src/integration-platform/controllers/connections.controller.ts b/apps/api/src/integration-platform/controllers/connections.controller.ts index 359ec36b11..0c7227f928 100644 --- a/apps/api/src/integration-platform/controllers/connections.controller.ts +++ b/apps/api/src/integration-platform/controllers/connections.controller.ts @@ -256,9 +256,13 @@ export class ConnectionsController { ? m.auth.config.credentialFields : m.credentialFields; - // Get setup instructions for custom auth + // Surface setup instructions for any credential-entry auth type (custom, api_key, + // basic, jwt) — not just custom. oauth2 is excluded because its setupInstructions are + // admin app-creation steps, not customer connect steps. const setupInstructions = - m.auth.type === 'custom' ? m.auth.config.setupInstructions : undefined; + m.auth.type !== 'oauth2' && 'setupInstructions' in m.auth.config + ? m.auth.config.setupInstructions + : undefined; const setupScript = m.auth.type === 'custom' ? m.auth.config.setupScript : undefined; @@ -372,9 +376,12 @@ export class ConnectionsController { ? manifest.auth.config.credentialFields : manifest.credentialFields; - // Get setup instructions for custom auth + // Surface setup instructions for any credential-entry auth type (custom, api_key, + // basic, jwt) — not just custom. oauth2 is excluded because its setupInstructions are + // admin app-creation steps, not customer connect steps. const setupInstructions = - manifest.auth.type === 'custom' + manifest.auth.type !== 'oauth2' && + 'setupInstructions' in manifest.auth.config ? manifest.auth.config.setupInstructions : undefined;