From 49e6c0704286720e617e5b26c91713b2bde38894 Mon Sep 17 00:00:00 2001 From: Eric Allam Date: Thu, 21 May 2026 14:14:40 +0100 Subject: [PATCH 1/2] ci: unblock changesets release PRs Two problems were blocking the v4.5.0-rc.0 release PR (and would block every future release PR): 1. The changesets bot pushes commits authored by GITHUB_TOKEN, which by GitHub design cannot trigger downstream workflows. That leaves the required "All PR Checks" status permanently Expected. Self-report a success check from changesets-pr.yml after PR creation. If a human ever pushes to changeset-release/main, the real pr_checks.yml fires and its result overwrites the auto-success (last write wins for the same context on the same SHA). 2. vouch-check-pr.yml's require-draft job auto-closed any non-draft PR from authors with author_association != MEMBER/OWNER/COLLABORATOR, exempting only devin-ai-integration[bot] and dependabot[bot]. The changesets bot publishes as github-actions[bot] (CONTRIBUTOR) and was getting slammed shut on reopen. Add it to the exemption list. --- .github/workflows/changesets-pr.yml | 25 +++++++++++++++++++++++++ .github/workflows/vouch-check-pr.yml | 3 ++- 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/.github/workflows/changesets-pr.yml b/.github/workflows/changesets-pr.yml index 01c303a95ca..2e52c9fdc88 100644 --- a/.github/workflows/changesets-pr.yml +++ b/.github/workflows/changesets-pr.yml @@ -22,6 +22,7 @@ jobs: permissions: contents: write pull-requests: write + checks: write if: github.repository == 'triggerdotdev/trigger.dev' steps: - name: Checkout @@ -72,3 +73,27 @@ jobs: -f body="$ENHANCED_BODY" fi fi + + # The changesets bot authors release PRs with GITHUB_TOKEN, which by GitHub + # design cannot trigger downstream workflows. That leaves the required + # "All PR Checks" status permanently Expected and the PR unmergeable. + # The release PR only bumps package.json + lockfile + CHANGELOGs from + # changesets already on main, so we self-report the required check as + # success. If a human ever pushes to changeset-release/main, the real + # pr_checks.yml fires and its result overwrites this one (last write wins + # for the same context on the same SHA). + - name: Self-report "All PR Checks" success on release PR + if: steps.changesets.outputs.published != 'true' + env: + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + run: | + PR_NUMBER=$(gh pr list --head changeset-release/main --json number --jq '.[0].number') + if [ -z "$PR_NUMBER" ]; then exit 0; fi + HEAD_SHA=$(gh pr view "$PR_NUMBER" --json headRefOid --jq '.headRefOid') + gh api -X POST repos/${{ github.repository }}/check-runs \ + -f name="All PR Checks" \ + -f head_sha="$HEAD_SHA" \ + -f status=completed \ + -f conclusion=success \ + -f 'output[title]=Auto-pass for changeset release PR' \ + -f 'output[summary]=Required check auto-satisfied for `changeset-release/main` PRs. Full CI ran on the underlying commits before they landed on main.' diff --git a/.github/workflows/vouch-check-pr.yml b/.github/workflows/vouch-check-pr.yml index 29090296bb0..d854b1e0ce6 100644 --- a/.github/workflows/vouch-check-pr.yml +++ b/.github/workflows/vouch-check-pr.yml @@ -32,7 +32,8 @@ jobs: github.event.pull_request.author_association != 'OWNER' && github.event.pull_request.author_association != 'COLLABORATOR' && github.event.pull_request.user.login != 'devin-ai-integration[bot]' && - github.event.pull_request.user.login != 'dependabot[bot]' + github.event.pull_request.user.login != 'dependabot[bot]' && + github.event.pull_request.user.login != 'github-actions[bot]' runs-on: ubuntu-latest steps: - name: Close non-draft PR From 87967e4da682ad5182ef9187af8dfd280a098ae5 Mon Sep 17 00:00:00 2001 From: Eric Allam Date: Thu, 21 May 2026 14:18:15 +0100 Subject: [PATCH 2/2] ci: drop backticks from check-run summary to satisfy shellcheck SC2016 Backticks inside the single-quoted -f 'output[summary]=...' string looked like command substitution to shellcheck, tripping actionlint. --- .github/workflows/changesets-pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/changesets-pr.yml b/.github/workflows/changesets-pr.yml index 2e52c9fdc88..66b7f24c656 100644 --- a/.github/workflows/changesets-pr.yml +++ b/.github/workflows/changesets-pr.yml @@ -96,4 +96,4 @@ jobs: -f status=completed \ -f conclusion=success \ -f 'output[title]=Auto-pass for changeset release PR' \ - -f 'output[summary]=Required check auto-satisfied for `changeset-release/main` PRs. Full CI ran on the underlying commits before they landed on main.' + -f 'output[summary]=Required check auto-satisfied for changeset-release/main PRs. Full CI ran on the underlying commits before they landed on main.'