BBCode shortcode parameter value chokes on the tag closing character

[MrPetovan]

Using CommonSyntax, the following text won't be picked up by the regular parser:
[url=http://example.com]link[/url]

The parser correctly recognize the opening shortcode, continue to getting the parameter value, then finds a /which is a marker token, then look for a closing token, doesn't find it and return false.

Using parameter delimiter like this [url="http://example.com"]link[/url] yields the expected result.

[thunderer]

@MrPetovan Your reasoning here and in #38 is correct, the RegularParser::value() method matches only "strings", ie. "not tokens" as parameter values. Mentioned URL contains shortcode token "closing mark", ie. forward slash /. Parameter value delimiters " will indeed solve the issue, but I think the generic whitespace delimited value should be possible. I'm working on the solution.

[MrPetovan]

For backward compatibility in my project, I need to be able to parse such shortcode.

I see two ways of solving it:

• Check that there’s a close token just after the marker token, or else keep on parsing the parameter value.
• Check that there’s a marker token just before a close token to decide it’s a self-closing tag.

Just throwing ideas around.

[thunderer]

@MrPetovan please look at #66. Please install the dev- composer version from the PR branch and verify that it works for your test cases. I added a quite thorough test for it, but I suspect there may be some uncovered edge cases. Let me know if all my answers so far and this PR solves all your issues. I'm always happy to answer more questions.

Flyers won their match, I had fun writing code, and it's nearly dawn at my place, so I'm going to a well-deserved sleep. :)

[rhukster]

I use a little workaround for wordpress parser:

    public function getBbCode($sc)
    {
        $code = null;

        if ($this->getParser() === 'wordpress') {
            $params = $sc->getParameters();
            if (is_array($params)) {
                $keys = array_keys($params);
                $code = trim(array_shift($keys), '=');
            }
        } else {
            $code = $sc->getBbCode();
        }
        return $code;
    }