From 5932741e39aa74cd5a0d259b65e397d22f9dc8a8 Mon Sep 17 00:00:00 2001 From: Chris Olszewski Date: Wed, 3 Jun 2026 14:15:46 -0400 Subject: [PATCH 1/2] Extract RBS updates --- temporalio/sig/temporalio/api/cloud/cloudservice.rbs | 8 ++++++++ temporalio/sig/temporalio/api/operatorservice.rbs | 6 ++++++ temporalio/sig/temporalio/api/workflowservice.rbs | 6 ++++++ temporalio/sig/temporalio/client/connection.rbs | 12 ++++-------- temporalio/sig/temporalio/client/workflow_handle.rbs | 1 + temporalio/sig/temporalio/converters.rbs | 4 ++++ temporalio/sig/temporalio/env_config.rbs | 8 ++++---- temporalio/sig/temporalio/internal.rbs | 4 ++++ temporalio/sig/temporalio/internal/bridge/api.rbs | 8 ++++++++ temporalio/sig/temporalio/internal/bridge/client.rbs | 4 ++-- temporalio/sig/temporalio/workflow/info.rbs | 4 ++-- temporalio/sig/temporalio/workflow/update_info.rbs | 2 +- 12 files changed, 50 insertions(+), 17 deletions(-) create mode 100644 temporalio/sig/temporalio/api/cloud/cloudservice.rbs create mode 100644 temporalio/sig/temporalio/api/operatorservice.rbs create mode 100644 temporalio/sig/temporalio/api/workflowservice.rbs create mode 100644 temporalio/sig/temporalio/converters.rbs create mode 100644 temporalio/sig/temporalio/internal.rbs create mode 100644 temporalio/sig/temporalio/internal/bridge/api.rbs diff --git a/temporalio/sig/temporalio/api/cloud/cloudservice.rbs b/temporalio/sig/temporalio/api/cloud/cloudservice.rbs new file mode 100644 index 00000000..dc9b888f --- /dev/null +++ b/temporalio/sig/temporalio/api/cloud/cloudservice.rbs @@ -0,0 +1,8 @@ +module Temporalio + module Api + module Cloud + module CloudService + end + end + end +end diff --git a/temporalio/sig/temporalio/api/operatorservice.rbs b/temporalio/sig/temporalio/api/operatorservice.rbs new file mode 100644 index 00000000..12e9a59d --- /dev/null +++ b/temporalio/sig/temporalio/api/operatorservice.rbs @@ -0,0 +1,6 @@ +module Temporalio + module Api + module OperatorService + end + end +end diff --git a/temporalio/sig/temporalio/api/workflowservice.rbs b/temporalio/sig/temporalio/api/workflowservice.rbs new file mode 100644 index 00000000..fa90fb7e --- /dev/null +++ b/temporalio/sig/temporalio/api/workflowservice.rbs @@ -0,0 +1,6 @@ +module Temporalio + module Api + module WorkflowService + end + end +end diff --git a/temporalio/sig/temporalio/client/connection.rbs b/temporalio/sig/temporalio/client/connection.rbs index 083b8c1f..1e2ed35f 100644 --- a/temporalio/sig/temporalio/client/connection.rbs +++ b/temporalio/sig/temporalio/client/connection.rbs @@ -97,13 +97,9 @@ module Temporalio attr_reader options: Options - # TODO(cretz): Update when generated - # attr_reader workflow_service: WorkflowService - # attr_reader operator_service: OperatorService - # attr_reader cloud_service: CloudService - attr_reader workflow_service: untyped - attr_reader operator_service: untyped - attr_reader cloud_service: untyped + attr_reader workflow_service: WorkflowService + attr_reader operator_service: OperatorService + attr_reader cloud_service: CloudService def initialize: ( target_host: String, @@ -131,4 +127,4 @@ module Temporalio private def new_core_client: -> Internal::Bridge::Client end end -end \ No newline at end of file +end diff --git a/temporalio/sig/temporalio/client/workflow_handle.rbs b/temporalio/sig/temporalio/client/workflow_handle.rbs index cb172f59..d1de854d 100644 --- a/temporalio/sig/temporalio/client/workflow_handle.rbs +++ b/temporalio/sig/temporalio/client/workflow_handle.rbs @@ -28,6 +28,7 @@ module Temporalio def fetch_history: ( ?event_filter_type: Integer, + ?skip_archival: bool, ?rpc_options: RPCOptions? ) -> WorkflowHistory diff --git a/temporalio/sig/temporalio/converters.rbs b/temporalio/sig/temporalio/converters.rbs new file mode 100644 index 00000000..2e29be31 --- /dev/null +++ b/temporalio/sig/temporalio/converters.rbs @@ -0,0 +1,4 @@ +module Temporalio + module Converters + end +end diff --git a/temporalio/sig/temporalio/env_config.rbs b/temporalio/sig/temporalio/env_config.rbs index 53290366..dbc3bfe1 100644 --- a/temporalio/sig/temporalio/env_config.rbs +++ b/temporalio/sig/temporalio/env_config.rbs @@ -21,7 +21,7 @@ module Temporalio ) -> void def to_h: -> Hash[Symbol, untyped] - def to_client_tls_options: -> (untyped | false) + def to_client_tls_options: -> (Client::Connection::TLSOptions | false) private @@ -34,7 +34,7 @@ module Temporalio attr_reader namespace: String? attr_reader api_key: String? attr_reader tls: ClientConfigTLS? - attr_reader grpc_meta: Hash[untyped, untyped] + attr_reader grpc_meta: Hash[String, String] def self.from_h: (Hash[untyped, untyped] hash) -> ClientConfigProfile @@ -52,7 +52,7 @@ module Temporalio ?namespace: String?, ?api_key: String?, ?tls: ClientConfigTLS?, - ?grpc_meta: Hash[untyped, untyped] + ?grpc_meta: Hash[String, String] ) -> void def to_h: -> Hash[Symbol, untyped] @@ -83,4 +83,4 @@ module Temporalio def to_h: -> Hash[String, Hash[Symbol, untyped]] end end -end \ No newline at end of file +end diff --git a/temporalio/sig/temporalio/internal.rbs b/temporalio/sig/temporalio/internal.rbs new file mode 100644 index 00000000..8e825e9d --- /dev/null +++ b/temporalio/sig/temporalio/internal.rbs @@ -0,0 +1,4 @@ +module Temporalio + module Internal + end +end diff --git a/temporalio/sig/temporalio/internal/bridge/api.rbs b/temporalio/sig/temporalio/internal/bridge/api.rbs new file mode 100644 index 00000000..8d423010 --- /dev/null +++ b/temporalio/sig/temporalio/internal/bridge/api.rbs @@ -0,0 +1,8 @@ +module Temporalio + module Internal + module Bridge + module Api + end + end + end +end diff --git a/temporalio/sig/temporalio/internal/bridge/client.rbs b/temporalio/sig/temporalio/internal/bridge/client.rbs index 7bf929d2..8d5cd36d 100644 --- a/temporalio/sig/temporalio/internal/bridge/client.rbs +++ b/temporalio/sig/temporalio/internal/bridge/client.rbs @@ -121,7 +121,7 @@ module Temporalio class RPCFailure < Error def code: -> Temporalio::Error::RPCError::Code::enum def message: -> String - def details: -> String + def details: -> String? end class CancellationToken @@ -131,4 +131,4 @@ module Temporalio end end end -end \ No newline at end of file +end diff --git a/temporalio/sig/temporalio/workflow/info.rbs b/temporalio/sig/temporalio/workflow/info.rbs index e8fc4b72..5fa9bd80 100644 --- a/temporalio/sig/temporalio/workflow/info.rbs +++ b/temporalio/sig/temporalio/workflow/info.rbs @@ -60,7 +60,7 @@ module Temporalio workflow_id: String ) -> void - def to_h: -> Hash[Symbol, untyped] + def to_h: -> Hash[Symbol, String] end class RootInfo @@ -72,7 +72,7 @@ module Temporalio workflow_id: String ) -> void - def to_h: -> Hash[Symbol, untyped] + def to_h: -> Hash[Symbol, String] end end end diff --git a/temporalio/sig/temporalio/workflow/update_info.rbs b/temporalio/sig/temporalio/workflow/update_info.rbs index 7d98f83e..0846a4c6 100644 --- a/temporalio/sig/temporalio/workflow/update_info.rbs +++ b/temporalio/sig/temporalio/workflow/update_info.rbs @@ -9,7 +9,7 @@ module Temporalio name: String ) -> void - def to_h: -> Hash[Symbol, untyped] + def to_h: -> Hash[Symbol, String] end end end From 66752b4cebeeb644599d3457d8dae31e7dbe3d14 Mon Sep 17 00:00:00 2001 From: Chris Olszewski Date: Wed, 3 Jun 2026 15:46:00 -0400 Subject: [PATCH 2/2] Remove stale generated service RBS files --- temporalio/sig/temporalio/api/cloud/cloudservice.rbs | 8 -------- temporalio/sig/temporalio/api/operatorservice.rbs | 6 ------ temporalio/sig/temporalio/api/workflowservice.rbs | 6 ------ 3 files changed, 20 deletions(-) delete mode 100644 temporalio/sig/temporalio/api/cloud/cloudservice.rbs delete mode 100644 temporalio/sig/temporalio/api/operatorservice.rbs delete mode 100644 temporalio/sig/temporalio/api/workflowservice.rbs diff --git a/temporalio/sig/temporalio/api/cloud/cloudservice.rbs b/temporalio/sig/temporalio/api/cloud/cloudservice.rbs deleted file mode 100644 index dc9b888f..00000000 --- a/temporalio/sig/temporalio/api/cloud/cloudservice.rbs +++ /dev/null @@ -1,8 +0,0 @@ -module Temporalio - module Api - module Cloud - module CloudService - end - end - end -end diff --git a/temporalio/sig/temporalio/api/operatorservice.rbs b/temporalio/sig/temporalio/api/operatorservice.rbs deleted file mode 100644 index 12e9a59d..00000000 --- a/temporalio/sig/temporalio/api/operatorservice.rbs +++ /dev/null @@ -1,6 +0,0 @@ -module Temporalio - module Api - module OperatorService - end - end -end diff --git a/temporalio/sig/temporalio/api/workflowservice.rbs b/temporalio/sig/temporalio/api/workflowservice.rbs deleted file mode 100644 index fa90fb7e..00000000 --- a/temporalio/sig/temporalio/api/workflowservice.rbs +++ /dev/null @@ -1,6 +0,0 @@ -module Temporalio - module Api - module WorkflowService - end - end -end