Skip to content

Improve echo'd status messaging colorblind friendliness #198

Description

@colindean

I'm using too much ANSI 32 green and 33 red together without icons, so colorblind folks can't really tell what's good and bad in Makefile output.

Change the colors variables here:

make-python-devex/Makefile

Lines 229 to 233 in 45abe28

COLOR_ORANGE = \033[33m
COLOR_BLUE = \033[34m
COLOR_RED = \033[31m
COLOR_GREEN = \033[32m
COLOR_RESET = \033[0m

to be named something like ANSI_COLOR_GREEN

and create status-related variables like

STATUS_GOOD = $(ANSI_COLOR_BLUE)

and set these STATUS_GOOD, STATUS_BAD, etc. to follow the blue/yellow/red color scheme everywhere but the US uses.

Lastly, change all the $(COLOR_GREEN) refs to $(STATUS_GOOD), etc.

E.g. in

make-python-devex/Makefile

Lines 249 to 253 in 45abe28

echo "$(COLOR_RED)Run your make command again after adding the above so that $(PYENV) is available.$(COLOR_RESET)"
.PHONY: deps-peru
deps-peru: .peru/lastimports ## Installs dependencies from Peru
@echo "$(COLOR_GREEN)All Peru modules sync'd!$(COLOR_RESET)"

Consider also injecting an emoji or at least ASCII indicators of status, e.g. ✅ or ❌ or just or so there's both an icon in the indicator as well as color.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions