From 0598db201e373211bc599979082f4319f560d516 Mon Sep 17 00:00:00 2001 From: dktue <2878623+dktue@users.noreply.github.com> Date: Thu, 29 Oct 2026 18:00:24 +0100 Subject: [PATCH 1/2] fix(filter_area): keep clipped slices of large polygons visible in the tile (#763) --- src/tile_worker.cpp | 33 ++++++++++++++++++++++++++------- 1 file changed, 26 insertions(+), 7 deletions(-) diff --git a/src/tile_worker.cpp b/src/tile_worker.cpp index 4f2f21d4..b56799be 100644 --- a/src/tile_worker.cpp +++ b/src/tile_worker.cpp @@ -99,20 +99,39 @@ void ReorderMultiLinestring(MultiLinestring &input, MultiLinestring &output) { } } -void RemovePartsBelowSize(MultiPolygon &g, double filterArea) { +// A small ring is dropped unless it is a slice cut by clipping that is visible in +// this tile. A ring strictly inside the tile's clipping box was not cut (the actual +// clip box is never smaller than clippingBox), so its area here is its real area. +// A ring entirely outside the tile itself only lies in the buffer and is never +// rendered here; the neighbouring tile judges it on its own. +static bool CanDropRing(const Ring &ring, const TileBbox &bbox) { + Box env = geom::return_envelope(ring); + const Box &clip = bbox.clippingBox; + bool insideClippingBox = + env.min_corner().x() > clip.min_corner().x() && + env.min_corner().y() > clip.min_corner().y() && + env.max_corner().x() < clip.max_corner().x() && + env.max_corner().y() < clip.max_corner().y(); + bool outsideTile = + env.max_corner().x() <= bbox.minLon || env.min_corner().x() >= bbox.maxLon || + env.max_corner().y() <= bbox.minLatp || env.min_corner().y() >= bbox.maxLatp; + return insideClippingBox || outsideTile; +} + +void RemovePartsBelowSize(MultiPolygon &g, double filterArea, const TileBbox &bbox) { g.erase(std::remove_if( g.begin(), g.end(), [&](const Polygon &poly) -> bool { - return std::fabs(geom::area(poly)) < filterArea; + return std::fabs(geom::area(poly)) < filterArea && CanDropRing(poly.outer(), bbox); }), g.end()); for (auto &outer : g) { outer.inners().erase(std::remove_if( - outer.inners().begin(), - outer.inners().end(), - [&](const Ring &inner) -> bool { - return std::fabs(geom::area(inner)) < filterArea; + outer.inners().begin(), + outer.inners().end(), + [&](const Ring &inner) -> bool { + return std::fabs(geom::area(inner)) < filterArea && CanDropRing(inner, bbox); }), outer.inners().end()); } @@ -448,7 +467,7 @@ void ProcessObjects( } if (oo.oo.geomType == POLYGON_ && filterArea > 0.0) { - RemovePartsBelowSize(boost::get(g), filterArea); + RemovePartsBelowSize(boost::get(g), filterArea, bbox); if (geom::is_empty(g)) continue; } From a2922575b6408aa0088987030f66c628200d93bb Mon Sep 17 00:00:00 2001 From: dktue <2878623+dktue@users.noreply.github.com> Date: Thu, 29 Oct 2026 18:16:55 +0100 Subject: [PATCH 2/2] style: keep original trailing whitespace in RemovePartsBelowSize --- src/tile_worker.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/tile_worker.cpp b/src/tile_worker.cpp index b56799be..16f17946 100644 --- a/src/tile_worker.cpp +++ b/src/tile_worker.cpp @@ -128,9 +128,9 @@ void RemovePartsBelowSize(MultiPolygon &g, double filterArea, const TileBbox &bb g.end()); for (auto &outer : g) { outer.inners().erase(std::remove_if( - outer.inners().begin(), - outer.inners().end(), - [&](const Ring &inner) -> bool { + outer.inners().begin(), + outer.inners().end(), + [&](const Ring &inner) -> bool { return std::fabs(geom::area(inner)) < filterArea && CanDropRing(inner, bbox); }), outer.inners().end());