From 417420e1f9bcdc13f096b663db2d0df5c684b4a7 Mon Sep 17 00:00:00 2001 From: sthings user Date: Tue, 19 May 2026 08:30:45 +0000 Subject: [PATCH] fix(comment-preview-url): unbreak workflow validation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Commit 97ebd538 added an `additional-urls` input whose `description` block embedded a literal `${{ github.event.number }}` expression inside the example string. GitHub Actions evaluates `${{ }}` even inside `description:` text, and `github.event.number` isn't resolvable at workflow-load time — every caller of this reusable workflow has been failing with "This run likely failed because of a workflow file issue" since the merge of #92 on 2026-05-18T12:40Z. Confirmed broken on: - stuttgart-things/homerun2-git-pitcher (first failure 37s after #92) - stuttgart-things/homerun2-led-catcher (every run on its new PR workflow set since landing) Rewords the example to a placeholder (`NUMBER`) with a one-line note pointing the reader at the caller-side expression. Pure docs change; no behaviour change for callers. Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/call-comment-preview-url.yaml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/call-comment-preview-url.yaml b/.github/workflows/call-comment-preview-url.yaml index ef0a614..0d6eb4d 100644 --- a/.github/workflows/call-comment-preview-url.yaml +++ b/.github/workflows/call-comment-preview-url.yaml @@ -42,15 +42,18 @@ on: default: "" type: string description: | - Optional comma-separated `Label=URL` pairs to append as extra rows + Optional comma-separated Label=URL pairs to append as extra rows in the comment table. Useful when the SUT's hostname isn't the actual review surface — e.g. git-pitcher exposes only /health and /metrics, but the events it produces are reviewed via a co-tenanted core-catcher dashboard. The caller can interpolate - `${{ github.event.number }}` into the URL. + the PR number expression into the URL. - Example: - additional-urls: 'Dashboard=https://cc-git-pr-${{ github.event.number }}.homerun2-dev.example.com' + Example (caller-side, with PR-number interpolation rendered): + additional-urls: 'Dashboard=https://cc-git-pr-NUMBER.homerun2-dev.example.com' + Replace NUMBER with the standard github.event.number expression + on the caller side; embedding the raw expression here would be + evaluated at workflow-load time and break parsing. permissions: pull-requests: write