From a3fae654059fd84f89003067d590c806647ed93c Mon Sep 17 00:00:00 2001 From: Athan Reines Date: Fri, 11 Sep 2026 10:16:54 +0000 Subject: [PATCH] test: migrate `stats/base/dists/frechet/stdev` to ULP-based assertions Replace relative tolerance assertions with `isAlmostSameValue` ULP comparisons. The measured minimum ULP bound over the full Julia fixture set is 12 for both the JavaScript and native implementations. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01NVM4G3stpWkuj632fLHnYP --- .../stats/base/dists/frechet/stdev/test/test.js | 13 ++----------- .../base/dists/frechet/stdev/test/test.native.js | 13 ++----------- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/frechet/stdev/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/frechet/stdev/test/test.js index c554f20adf47..2d917573e356 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/frechet/stdev/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/frechet/stdev/test/test.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var stdev = require( './../lib' ); @@ -97,8 +96,6 @@ tape( 'if provided a nonpositive `s`, the function returns `NaN`', function test tape( 'the function returns the standard deviation of a Fréchet distribution', function test( t ) { var expected; var alpha; - var delta; - var tol; var s; var y; var i; @@ -109,13 +106,7 @@ tape( 'the function returns the standard deviation of a Fréchet distribution', for ( i = 0; i < alpha.length; i++ ) { y = stdev( alpha[i], s[i], 0.0 ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'alpha:'+alpha[i]+', s: '+s[i]+', m: 0, y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 10.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. alpha: '+alpha[i]+'. s: '+s[i]+'. m: 0. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 12 ), true, 'returns expected value' ); } } t.end(); diff --git a/lib/node_modules/@stdlib/stats/base/dists/frechet/stdev/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/frechet/stdev/test/test.native.js index e5c8dfd5ed87..8d6a3be765ce 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/frechet/stdev/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/frechet/stdev/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var tryRequire = require( '@stdlib/utils/try-require' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -112,8 +111,6 @@ tape( 'if provided a nonpositive `s`, the function returns `NaN`', opts, functio tape( 'the function returns the standard deviation of a Fréchet distribution', opts, function test( t ) { var expected; var alpha; - var delta; - var tol; var s; var y; var i; @@ -124,13 +121,7 @@ tape( 'the function returns the standard deviation of a Fréchet distribution', for ( i = 0; i < alpha.length; i++ ) { y = stdev( alpha[i], s[i], 0.0 ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'alpha:'+alpha[i]+', s: '+s[i]+', m: 0, y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 10.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. alpha: '+alpha[i]+'. s: '+s[i]+'. m: 0. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 12 ), true, 'returns expected value' ); } } t.end();