removed dependency from ActiveSupport, fixed bugs

Author: v-dolgishev

Gemfile.lock

@@ -1,25 +1,12 @@
 PATH
   remote: .
   specs:
-    stackify-api-ruby (1.0.0)
-      activesupport (~> 4.1, >= 4.1.1)
+    stackify-api-ruby (1.0.2)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (4.1.4)
-      i18n (~> 0.6, >= 0.6.9)
-      json (~> 1.7, >= 1.7.7)
-      minitest (~> 5.1)
-      thread_safe (~> 0.1)
-      tzinfo (~> 1.1)
-    i18n (0.6.11)
-    json (1.8.1)
-    minitest (5.4.0)
     rake (0.9.6)
-    thread_safe (0.3.4)
-    tzinfo (1.2.1)
-      thread_safe (~> 0.1)
 
 PLATFORMS
   ruby

README.md

@@ -24,14 +24,13 @@ After you install stackify-api-ruby you need to run the generator:
 
     $ rails g stackify --api_key=your_api_key
 
-The generator creates a file under config/initializers/stackify.rb configuring stackify-api-ruby with your API key. You can change default settings there.
+The generator creates a file 'config/initializers/stackify.rb' configuring stackify-api-ruby with your API key. You can change default settings there.
 
 Usage: Logging
 ------------------
-
 ### Rails Environment
 
-stackify-api-ruby starts working with start of Rails. Every occured error will be cought and sent to Stackify automatically. The same situation with logs - you just use the Rails logger as usual:
+stackify-api-ruby starts with start of Rails. Every error, which occurs within your application, will be caught and sent to Stackify automatically. The same situation with logs - you just use the Rails logger as usual:
 
     Rails.logger.info "Some log message"
 
@@ -46,8 +45,8 @@ After that you need to make base configuration:
     Stackify.setup do |config|
       config.api_key = "your_api_key"
       config.env = :development
-      config.app_name =  "Your's app name"
-      config.app_location =  "/somewhere/public"
+      config.app_name = "Your app name"
+      config.app_location = "/somewhere/public"
     end
 
 "api_key" - it's you key for Stackify. "app-location" - it's location of your application for Nginx/Apache(for Nginx it's value of 'root', for Apache it's value of 'DocumentRoot' at config files).
@@ -61,31 +60,19 @@ You can set minimal level of logs, which should be caught by gem:
 
     config.log_level = :error
 
-By default, gem sends logs to Stackify every 60 seconds, you can increase this value to higher if need:
-
-    config.send_interval = 60 #value in seconds, could not be less than 60 seconds
-
-All logs, errors, and metrics are queued within the gem and uploaded on a background thread. By default, the maximum amount of logs is 1,000 log items, you can decrease this value:
-
-    config.queue_max_size = 600
-
-To help prevent flooding the system there is a parameter - max amount of the same error per minute:
-
-    config.flood_limit = 100
-
-If you want to use proxy for sendig request, you can do it in such way:
+If you want to use proxy for sending request, you can do it in such way:
 
     config.with_proxy = true
     config.proxy_host = "127.0.0.1"
     config.proxy_port = "8118"
     config.proxy_user = nil
     config.proxy_pass = nil
 
-For logging own work stackify-api-rubystackify-api-rubygem uses such logger:
+For internal logging stackify-api-ruby uses such logger:
 
     config.logger = Logger.new(File.join(Rails.root, "log", "stackify.log"))
 
-After set up of logs you should wrap up your logger:
+After logs configuring you should wrap up your logger:
 
     logger = Logger.new('mylog.log')
     logger = Stackify::LoggerProxy.new(logger)
@@ -124,7 +111,7 @@ There are four different types of metrics:
 
 We can configure every metric with settings:
 
-        settings  = MetricSettings.new
+        settings = MetricSettings.new
         settings.autoreport_zero_if_nothing_reported = true
         # or
         settings.autoreport_last_value_if_nothing_reported = true

lib/core_ext/core_ext.rb

@@ -0,0 +1,3 @@
+require 'json'
+require 'core_ext/object'
+require 'core_ext/fixnum'

lib/core_ext/fixnum.rb

@@ -0,0 +1,17 @@
+class Fixnum
+  SECONDS_IN_MINUTE = 60
+  SECONDS_IN_HOUR =  60 * SECONDS_IN_MINUTE
+  SECONDS_IN_DAY = 24 * SECONDS_IN_HOUR
+
+  def days
+    self * SECONDS_IN_DAY
+  end
+
+  def minutes
+    self * SECONDS_IN_MINUTE
+  end
+
+  def ago
+    Time.now - self
+  end
+end

lib/core_ext/object.rb

@@ -0,0 +1,9 @@
+class Object
+  def try(*a, &b)
+    if a.empty? && block_given?
+      yield self
+    else
+      public_send(*a, &b) if respond_to?(a.first)
+    end
+  end
+end

lib/generators/stackify/templates/stackify.rb

@@ -1,11 +1,8 @@
 Stackify.setup do |config|
   config.api_key = '<%= options[:api_key] %>'
   #config.mode = :both
-  #config.app_name =  "Your's app name"
+  #config.app_name = "Your's app name"
   #config.env = :development
-  #config.flood_limit = 100
-  #config.queue_max_size = 1000
-  #config.send_interval = 60 #sec
   #config.log_level = :error
   #config.logger = Logger.new(File.join(Rails.root, 'log', 'stackify.log'))
   #config.logger.level = Logger::INFO

lib/stackify-api-ruby.rb

@@ -1,6 +1,6 @@
 require 'stackify/version'
 require 'stackify/utils/methods'
-require 'active_support/core_ext' unless defined? Rails
+require 'core_ext/core_ext' unless defined? Rails
 
 module Stackify
 
@@ -39,14 +39,14 @@ def configuration
     end
 
     def setup
+      @workers = []
       yield(configuration) if block_given?
       if configuration.is_valid?
         @status = STATUSES[:working]
-        @workers = []
       else
         msg = "Stackify's configuration is not valid!"
         configuration.errors.each do |error_msg|
-          msg += "\n"+error_msg
+          msg += "\n" + error_msg
         end
         raise msg
       end
@@ -70,6 +70,7 @@ def logger
     end
 
     def shutdown_all caller_obj=nil
+      Stackify.status = Stackify::STATUSES[:terminating]
       @workers.each do |worker|
         worker.shutdown! unless worker.equal? caller_obj
       end
@@ -116,6 +117,8 @@ def run async = true
           t1.join
           t2.join if t2
         end
+      else
+        Stackify.log_internal_error "Stackify is not properly configured! Errors: #{Stackify.configuration.errors}"
       end
     end
 

lib/stackify/authorization/authorizable.rb

@@ -9,7 +9,7 @@ module ClassMethods
     @@authorized = false
     @@auth_lock = Mutex.new
     @@auth_client = nil
-        
+
     def authorize attempts=3, delay_time = 20
       @@auth_lock.synchronize do
         return unless @@auth_client.nil?
@@ -19,7 +19,7 @@ def authorize attempts=3, delay_time = 20
     end
 
     def authorized?
-      @@auth_lock.synchronize do 
+      @@auth_lock.synchronize do
         @@authorized
       end
     end

lib/stackify/authorization/authorization_client.rb

@@ -1,8 +1,7 @@
 module Stackify::Authorizable
-
   class AuthorizationClient < Stackify::HttpClient
 
-    BASE_URI = URI(Stackify.configuration.api_urls[:auth])
+    BASE_URI = URI("#{Stackify.configuration.base_api_url}/Metrics/IdentifyApp")
 
     def initialize
       super

lib/stackify/env_details.rb

@@ -9,13 +9,13 @@ class EnvDetails
     def initialize
       rails_info = defined?(Rails) ? Rails::Info.properties.to_h : nil
       @info =  rails_info || { 'Application root' => Dir.pwd, 'Environment' => 'development'}
-      @request_details = nil
+      @request_details = {}
       @app_name = app_name
       app_location = Stackify.configuration.app_location || @info['Application root']
       @details = {
         'DeviceName' => Socket.gethostname,
         'AppLocation' => app_location,
-        'AppName' => @app_name, 
+        'AppName' => @app_name,
         'ConfiguredAppName' => @app_name,
         'ConfiguredEnvironmentName' =>@info['Environment']
       }
@@ -73,7 +73,7 @@ def app_location
     end
 
     def cookies env
-      env['action_dispatch.cookies'].to_h
+      env['action_dispatch.cookies'].try(:to_h)
     end
 
     def headers env