Merge pull request #5 from blackopseng3/master

Logger Exception handling improvements

Author: eric-martin

lib/stackify-api-ruby.rb

@@ -27,6 +27,7 @@ module Stackify
   autoload :LogsSender,           'stackify/logs_sender'
   autoload :LoggerProxy,          'stackify/logger_proxy'
   autoload :StackifiedError,      'stackify/error'
+  autoload :StringException,      'stackify/error'
   autoload :ErrorsGovernor,       'stackify/errors_governor'
   autoload :Metrics,              'stackify/metrics/metrics'
 

lib/stackify/error.rb

@@ -1,5 +1,9 @@
 module Stackify
-
+  class StringException < StandardError
+    def class
+      'StringException'.freeze
+    end
+  end
   class StackifiedError < StandardError
 
     CONTEXT_PROPERTIES =  { 'user' => 'current_user'}

lib/stackify/logger_client.rb

@@ -58,10 +58,20 @@ def is_appropriate_env?
 
     def log_message_task level, msg, call_trace
       Stackify::ScheduleTask.new ({limit: 1}) do
-        e = Exception.new(msg)
-        e.set_backtrace(call_trace)
-        ex = StackifiedError.new(e, binding())
-        Stackify.msgs_queue << Stackify::MsgObject.new(level, ex.message, caller[0], ex).to_h
+        if %w(error fatal).include?(level)
+          ex = if ruby_exception?(msg) && msg.class != Class
+            msg.set_backtrace(call_trace)
+            msg
+          else
+            e = StringException.new(msg)
+            e.set_backtrace(call_trace)
+            e
+          end
+          ex = StackifiedError.new(ex, binding())
+          Stackify.msgs_queue << Stackify::MsgObject.new(level, ex.message, caller[0], ex).to_h
+        else
+          Stackify.msgs_queue << Stackify::MsgObject.new(level, msg, caller[0]).to_h
+        end
       end
     end
 
@@ -70,6 +80,16 @@ def log_exception_task level, ex
         Stackify.msgs_queue << Stackify::MsgObject.new(level, ex.message, caller[0], ex).to_h
       end
     end
+
+    def ruby_exception? klass
+      klass = klass.class == Class ? klass : klass.class
+      klasses = [klass]
+      while klass != Object do
+        klasses << klass.superclass
+        klass = klass.superclass
+      end
+      klasses.include?(Exception)
+    end
   end
 
 end