Fronius GEN24 Setup Guide in Document outdated

[metabubble]

Describe the bug
Documentation states, "Download fronius_battery_control.py from fronius-modbus-control". The file provided here uses a different set of parameters than the ones from the configuration example.

options:
  -h, --help            show this help message and exit
  --action {force_charge,force_discharge,hold,reset,status}
                        Control action to perform
  --host HOST           Inverter IP address
  --port PORT           Modbus TCP port (default: 502)
  --slave SLAVE         Modbus slave ID (default: 1)
  --rate RATE           Charge/discharge rate in watts (default: inverter max)
  --rvrt RVRT           Revert timer in seconds (default: 900, 0=disabled)
  --no-verify           Skip write verification
  --json                Output as JSON
  --retries RETRIES     Connection retries (default: 3)

In addition there are no more charge_freeze and discharge_freeze.

I am sharing my updated shell_command portion.

shell_command:
  fronius_force_charge: >
    python3 /config/fronius_battery_control.py
    --host 10.0.0.180
    --action force_charge
    --rate {{ charge_power }}
    --rvrt 900
  fronius_force_discharge: >
    python3 /config/fronius_battery_control.py
    --host 10.0.0.180
    --action force_discharge
    --rate {{ discharge_power }}
    --rvrt 900
  fronius_charge_freeze: >
    python3 /config/fronius_battery_control.py
    --host 10.0.0.180
    --action hold
    --rvrt 900
  fronius_discharge_freeze: >
    python3 /config/fronius_battery_control.py
    --host 10.0.0.180
    --action hold
    --rvrt 900
  fronius_reset: >
    python3 /config/fronius_battery_control.py
    --host 10.0.0.180
    --action reset

Before using predbat, I used to send these commands through the modbus integration, setup was minimal

modbus:
  - type: tcp
    # Put your Gen24 IP address here
    host: 10.0.0.180
    port: 502
    name: gen24

If desired, I could use a rainy day in the future to migrate from the python script to a fully home assistant native one just using modbus.write_register, to reduce the dependency on that external script, which might change parameters again.

[gcoan]

could you propose a PR to update the documentation, or advise what changes are needed and I can update it

thanks

[metabubble]

That depends. Is a solution involving a third party script favorable to having these commands sent by home assistant through the modbus integration? If modbus is favorable, I would not mind implementing it within the next 7-10 days and writing a PR for the documentation.

[gcoan]

I would think a modbus connection where it's all configured via HA would be preferable. This follows the pattern of pretty much all the other inverter integrations, and should mean the most control of the inverter capabilities rather than going via a 3rd party script

[metabubble]

Not quite versed in github, only worked with git in the past. PR is here #3650

[gcoan]

Documentation updated, thanks for the PR