From 42de2e1f6bf3ad46b6f195d273b4657ae9c32ce8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Seungcheol=20Kwon=20=28=EA=B6=8C=EC=8A=B9=EC=B2=A0=29?= Date: Thu, 22 Jan 2026 13:41:48 +0900 Subject: [PATCH] GH-3170: Change default requiredAcks to all MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Seungcheol Kwon (권승철) --- .../properties/KafkaBinderConfigurationProperties.java | 2 +- .../KafkaBinderConfigurationPropertiesTest.java | 10 ++++++++++ .../ROOT/pages/kafka/kafka-binder/config-options.adoc | 2 +- docs/modules/ROOT/pages/kafka/kafka_overview.adoc | 2 +- 4 files changed, 13 insertions(+), 3 deletions(-) diff --git a/binders/kafka-binder/spring-cloud-stream-binder-kafka-core/src/main/java/org/springframework/cloud/stream/binder/kafka/properties/KafkaBinderConfigurationProperties.java b/binders/kafka-binder/spring-cloud-stream-binder-kafka-core/src/main/java/org/springframework/cloud/stream/binder/kafka/properties/KafkaBinderConfigurationProperties.java index e0650e1eb0..aba61d5340 100644 --- a/binders/kafka-binder/spring-cloud-stream-binder-kafka-core/src/main/java/org/springframework/cloud/stream/binder/kafka/properties/KafkaBinderConfigurationProperties.java +++ b/binders/kafka-binder/spring-cloud-stream-binder-kafka-core/src/main/java/org/springframework/cloud/stream/binder/kafka/properties/KafkaBinderConfigurationProperties.java @@ -110,7 +110,7 @@ public class KafkaBinderConfigurationProperties { private boolean considerDownWhenAnyPartitionHasNoLeader = true; - private String requiredAcks = "1"; + private String requiredAcks = "all"; private short replicationFactor = -1; diff --git a/binders/kafka-binder/spring-cloud-stream-binder-kafka-core/src/test/java/org/springframework/cloud/stream/binder/kafka/properties/KafkaBinderConfigurationPropertiesTest.java b/binders/kafka-binder/spring-cloud-stream-binder-kafka-core/src/test/java/org/springframework/cloud/stream/binder/kafka/properties/KafkaBinderConfigurationPropertiesTest.java index bfd16aba6d..04634a159f 100644 --- a/binders/kafka-binder/spring-cloud-stream-binder-kafka-core/src/test/java/org/springframework/cloud/stream/binder/kafka/properties/KafkaBinderConfigurationPropertiesTest.java +++ b/binders/kafka-binder/spring-cloud-stream-binder-kafka-core/src/test/java/org/springframework/cloud/stream/binder/kafka/properties/KafkaBinderConfigurationPropertiesTest.java @@ -37,6 +37,16 @@ class KafkaBinderConfigurationPropertiesTest { + @Test + @SuppressWarnings("unchecked") + void defaultRequiredAcksIsAll() { + KafkaProperties kafkaProperties = new KafkaProperties(); + KafkaBinderConfigurationProperties kafkaBinderConfigurationProperties = + new KafkaBinderConfigurationProperties(kafkaProperties, mock(ObjectProvider.class)); + + assertThat(kafkaBinderConfigurationProperties.getRequiredAcks()).isEqualTo("all"); + } + @Test @SuppressWarnings("unchecked") void mergedConsumerConfigurationFiltersGroupIdFromKafkaProperties() { diff --git a/docs/modules/ROOT/pages/kafka/kafka-binder/config-options.adoc b/docs/modules/ROOT/pages/kafka/kafka-binder/config-options.adoc index c2e87266b9..d59d389b57 100644 --- a/docs/modules/ROOT/pages/kafka/kafka-binder/config-options.adoc +++ b/docs/modules/ROOT/pages/kafka/kafka-binder/config-options.adoc @@ -43,7 +43,7 @@ spring.cloud.stream.kafka.binder.requiredAcks:: The number of required acks on the broker. See the Kafka documentation for the producer `acks` property. + -Default: `1`. +Default: `all`. spring.cloud.stream.kafka.binder.minPartitionCount:: Effective only if `autoCreateTopics` or `autoAddPartitions` is set. The global minimum number of partitions that the binder configures on topics on which it produces or consumes data. diff --git a/docs/modules/ROOT/pages/kafka/kafka_overview.adoc b/docs/modules/ROOT/pages/kafka/kafka_overview.adoc index f812b3a490..63b72cabdb 100644 --- a/docs/modules/ROOT/pages/kafka/kafka_overview.adoc +++ b/docs/modules/ROOT/pages/kafka/kafka_overview.adoc @@ -83,7 +83,7 @@ spring.cloud.stream.kafka.binder.requiredAcks:: The number of required acks on the broker. See the Kafka documentation for the producer `acks` property. + -Default: `1`. +Default: `all`. spring.cloud.stream.kafka.binder.minPartitionCount:: Effective only if `autoCreateTopics` or `autoAddPartitions` is set. The global minimum number of partitions that the binder configures on topics on which it produces or consumes data.