Upgrade JS-commons

Author: EmilianoSanchez

package-lock.json

@@ -38,7 +38,7 @@
     "node": ">=14.0.0"
   },
   "dependencies": {
-    "@splitsoftware/splitio-commons": "3.0.0-rc.7",
+    "@splitsoftware/splitio-commons": "3.0.1-rc.3",
     "bloom-filters": "^3.0.4",
     "ioredis": "^4.28.0 || ^5.0.0",
     "js-yaml": "^4.2.0",

package.json

@@ -43,9 +43,10 @@ export default function (assert) {
     client.getTreatment({ matchingKey: 'marcio@split.io', bucketingKey: 'impr_bucketing_2' }, 'qc_team');
     client.getTreatment('facundo@split.io', 'qc_team', testAttrs);
     client.getTreatment('facundo@split.io', 'qc_team', testAttrs);
+    client.getTreatment('trevor@split.io', 'qc_team');
 
     setTimeout(() => {
-      assert.equal(listener.logImpression.callCount, 4, 'Impression listener logImpression method should be called after we call client.getTreatment, once per each impression generated.');
+      assert.equal(listener.logImpression.callCount, 5, 'Impression listener logImpression method should be called after we call client.getTreatment, once per each impression generated.');
       assert.true(listener.logImpression.getCall(0).calledWithExactly({
         impression: {
           feature: 'hierarchical_splits_test',
@@ -94,6 +95,16 @@ export default function (assert) {
         attributes: testAttrs,
         ...metaData
       }));
+      assert.true(listener.logImpression.getCall(4).calledWithMatch({
+        impression: {
+          feature: 'qc_team',
+          keyName: 'trevor@split.io',
+          treatment: 'yes',
+          bucketingKey: undefined,
+          label: '',
+        },
+        ...metaData
+      }));
 
       client.destroy();
       assert.end();

src/__tests__/nodeSuites/impressions-listener.spec.js

@@ -60,7 +60,6 @@ function getModules(settings) {
     case LOCALHOST_MODE:
       modules.serviceApiFactory = undefined;
       modules.syncManagerFactory = localhostFromObjectFactory;
-      modules.SignalListener = undefined;
       break;
   }
 

src/factory/browser.js

@@ -65,7 +65,6 @@ function getModules(settings) {
     case LOCALHOST_MODE:
       modules.serviceApiFactory = undefined;
       modules.syncManagerFactory = localhostFromFileFactory;
-      modules.SignalListener = undefined;
       break;
     case CONSUMER_MODE:
       modules.syncManagerFactory = undefined;