From 6c6b93659ee5631c3aa077d0ed31bc977f993fe8 Mon Sep 17 00:00:00 2001 From: Claudio Ferraro <54107647+jbclaudio@users.noreply.github.com> Date: Mon, 16 May 2022 13:49:00 +0200 Subject: [PATCH 1/2] Declare optional parameter before required parameters. Optional parameter $data should be declared before required parameters. --- Block/Frontend/SmartsuppBlock.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Block/Frontend/SmartsuppBlock.php b/Block/Frontend/SmartsuppBlock.php index 5aebc07..729002f 100644 --- a/Block/Frontend/SmartsuppBlock.php +++ b/Block/Frontend/SmartsuppBlock.php @@ -36,10 +36,10 @@ class SmartsuppBlock extends Template public function __construct( Context $context, - array $data = [], ProductMetadataInterface $productMetadata, Data $dataHelper, - ObjectManagerInterface $objectManager + ObjectManagerInterface $objectManager, + array $data = [] ) { parent::__construct($context, $data); $this->productMetadata = $productMetadata; From e5428675bbf4c5a6c3e739313801b21b9b5da6df Mon Sep 17 00:00:00 2001 From: Claudio Ferraro <54107647+jbclaudio@users.noreply.github.com> Date: Wed, 18 May 2022 11:17:23 +0200 Subject: [PATCH 2/2] Allow all versions of chat-code-generator --- composer.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/composer.json b/composer.json index 8a19617..7493531 100644 --- a/composer.json +++ b/composer.json @@ -13,7 +13,7 @@ } }, "require": { - "smartsupp/chat-code-generator": "1.*", + "smartsupp/chat-code-generator": "*", "smartsupp/php-partner-client": "1.*" } -} \ No newline at end of file +}