From 2ea58e9bcabc064f500cf5c21307ede4df725be7 Mon Sep 17 00:00:00 2001
From: Algis Dumbris <a.dumbris@gmail.com>
Date: Mon, 15 Jun 2026 16:11:23 +0300
Subject: [PATCH] test(runtime): skip heavy quarantine property tests on
 Windows

The three rapid-based property tests (TestRapidQuarantineStateMachine,
TestRapidInvariant_ChangedNeverAutoApproved, TestRapidInvariant_PendingNeverAutoApproved)
each create and tear down hundreds of BBolt-backed Runtimes per rapid.Check
run. Under -race they take several minutes; on Windows the slower file
IO/timers push them past the 5m package timeout of the Unit Tests
(windows-latest) job, which runs 'go test -race -timeout 5m ./...' without
-short. This produced flaky 'panic: test timed out after 5m0s' reds in
internal/runtime unrelated to any PR change (#675, #685, #684).

The existing testing.Short() guards never fire because the job omits -short.
Add a documented Windows skip (mirroring apply_config_restart_test.go) to the
offending tests only. The invariants they assert are platform-independent, so
Linux/macOS coverage plus the dedicated heavy-runtime CI job is sufficient.
The global timeout is left untouched.

Related #MCP-2493
---
 .../runtime/tool_quarantine_invariant_test.go | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/internal/runtime/tool_quarantine_invariant_test.go b/internal/runtime/tool_quarantine_invariant_test.go
index 223c4ac7..7264ddab 100644
--- a/internal/runtime/tool_quarantine_invariant_test.go
+++ b/internal/runtime/tool_quarantine_invariant_test.go
@@ -3,6 +3,7 @@ package runtime
 import (
 	"fmt"
 	"os"
+	"runtime"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -14,6 +15,26 @@ import (
 	"github.com/smart-mcp-proxy/mcpproxy-go/internal/storage"
 )
 
+// skipQuarantinePropertyTestOnWindows skips the rapid-based property tests below
+// on Windows. Each rapid.Check iteration creates and tears down a full
+// BBolt-backed Runtime in a temp dir; with hundreds of iterations under `-race`
+// these tests run for several minutes. On Windows the slower file IO/timers push
+// them past the 5m package timeout of the Unit Tests (windows-latest) job, which
+// runs `go test -race -timeout 5m ./...` without `-short`, producing flaky
+// "panic: test timed out after 5m0s" reds in internal/runtime (MCP-2493).
+//
+// The invariants these tests assert (tool-approval hash + storage state machine)
+// are platform-independent, so full coverage on Linux/macOS — plus the dedicated
+// heavy-runtime CI job — is sufficient. This mirrors the existing Windows skip in
+// apply_config_restart_test.go.
+func skipQuarantinePropertyTestOnWindows(t *testing.T) {
+	t.Helper()
+	if runtime.GOOS == "windows" {
+		t.Skip("heavy rapid property test exceeds the 5m Windows -race package timeout (MCP-2493); " +
+			"platform-independent invariants are fully covered on Linux/macOS and the heavy-runtime CI job")
+	}
+}
+
 // =============================================================================
 // Unit tests for assertToolApprovalInvariant
 // =============================================================================
@@ -356,6 +377,7 @@ func TestRapidQuarantineStateMachine(t *testing.T) {
 	if testing.Short() {
 		t.Skip("heavy property test (~270s under -race); runs in the stress-tests CI job")
 	}
+	skipQuarantinePropertyTestOnWindows(t)
 	rapid.Check(t, func(t *rapid.T) {
 		// Set up runtime with quarantine enabled
 		tempDir, err := os.MkdirTemp("", "quarantine-rapid-*")
@@ -504,6 +526,7 @@ func TestRapidInvariant_ChangedNeverAutoApproved(t *testing.T) {
 	if testing.Short() {
 		t.Skip("heavy property test (~70s under -race); runs in the stress-tests CI job")
 	}
+	skipQuarantinePropertyTestOnWindows(t)
 	rapid.Check(t, func(t *rapid.T) {
 		tempDir, err := os.MkdirTemp("", "quarantine-changed-*")
 		if err != nil {
@@ -585,6 +608,7 @@ func TestRapidInvariant_ChangedNeverAutoApproved(t *testing.T) {
 // TestRapidInvariant_PendingNeverAutoApproved is a focused property test that
 // verifies pending tools never auto-approve when quarantine is enabled.
 func TestRapidInvariant_PendingNeverAutoApproved(t *testing.T) {
+	skipQuarantinePropertyTestOnWindows(t)
 	rapid.Check(t, func(t *rapid.T) {
 		tempDir, err := os.MkdirTemp("", "quarantine-pending-*")
 		if err != nil {