fix(dataverse): preserve legacy reconnect behavior

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/credential-selector/credential-selector.tsx

@@ -209,11 +209,10 @@ export function CredentialSelector({
     ? getMissingRequiredScopes(selectedCredential!, requiredScopes || [])
     : []
   const needsUpdate =
-    hasOAuthSelection &&
     !isServiceAccount &&
-    (missingRequiredScopes.length > 0 ||
-      dataversePolicy.requiresSeparateCredential ||
-      dataversePolicy.hasInvalidEnvironment) &&
+    (dataversePolicy.hasInvalidEnvironment ||
+      (hasOAuthSelection &&
+        (missingRequiredScopes.length > 0 || dataversePolicy.requiresSeparateCredential))) &&
     !effectiveDisabled &&
     !isPreview &&
     !credentialsLoading

apps/sim/hooks/queries/oauth/microsoft-dataverse-connections.test.ts

@@ -185,6 +185,12 @@ describe('Microsoft Dataverse OAuth connections', () => {
         credentialQueryFailed: false,
       })
     ).toThrow('Sim web app')
+    expect(() =>
+      assertMicrosoftDataverseReconnectAvailable({
+        bindingState: 'legacy',
+        credentialQueryFailed: false,
+      })
+    ).not.toThrow()
   })
 
   it.each([

apps/sim/hooks/queries/oauth/microsoft-dataverse-connections.ts

@@ -63,7 +63,6 @@ export function assertMicrosoftDataverseReconnectAvailable({
   bindingState,
   credentialQueryFailed,
 }: AssertMicrosoftDataverseReconnectAvailableParams): void {
-  assertMicrosoftDataverseWebOAuthAvailable()
   if (credentialQueryFailed) {
     throw new Error(
       'Could not verify this Dataverse credential’s environment binding. Please try again.'
@@ -74,6 +73,7 @@ export function assertMicrosoftDataverseReconnectAvailable({
       'This Dataverse credential has an invalid environment binding and cannot be reconnected in place.'
     )
   }
+  if (bindingState === 'bound') assertMicrosoftDataverseWebOAuthAvailable()
 }
 
 export function useConnectMicrosoftDataverseOAuthService() {