ack PR comments

Author: waleedlatif1

apps/sim/app/api/settings/allowed-mcp-domains/route.ts

@@ -1,8 +1,14 @@
 import { NextResponse } from 'next/server'
+import { getSession } from '@/lib/auth'
 import { getAllowedMcpDomainsFromEnv } from '@/lib/core/config/feature-flags'
 import { getBaseUrl } from '@/lib/core/utils/urls'
 
 export async function GET() {
+  const session = await getSession()
+  if (!session?.user?.id) {
+    return NextResponse.json({ error: 'Unauthorized' }, { status: 401 })
+  }
+
   const configuredDomains = getAllowedMcpDomainsFromEnv()
   if (configuredDomains === null) {
     return NextResponse.json({ allowedMcpDomains: null })

apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/settings-modal/components/mcp/mcp.tsx

@@ -117,7 +117,7 @@ function isDomainAllowed(url: string | undefined, allowedDomains: string[] | nul
     const hostname = new URL(url).hostname.toLowerCase()
     return allowedDomains.includes(hostname)
   } catch {
-    return true
+    return false
   }
 }
 

apps/sim/lib/mcp/domain-check.ts

@@ -9,19 +9,17 @@ export class McpDomainNotAllowedError extends Error {
 }
 
 let cachedPlatformHostname: string | null = null
-let platformHostnameResolved = false
 
 /**
  * Returns the platform's own hostname (from getBaseUrl), lazy-cached.
  * Always lowercase. Returns null if the base URL is not configured or invalid.
  */
 function getPlatformHostname(): string | null {
-  if (platformHostnameResolved) return cachedPlatformHostname
-  platformHostnameResolved = true
+  if (cachedPlatformHostname !== null) return cachedPlatformHostname
   try {
     cachedPlatformHostname = new URL(getBaseUrl()).hostname.toLowerCase()
   } catch {
-    cachedPlatformHostname = null
+    return null
   }
   return cachedPlatformHostname
 }