address comments

Author: icecrasher321

apps/sim/app/api/knowledge/utils.test.ts

@@ -259,7 +259,12 @@ describe('Knowledge Utils', () => {
         {}
       )
 
-      expect(dbOps.order).toEqual(['insert', 'updateDoc'])
+      // Embeddings are inserted first, then the document counter update. A
+      // usage_log billing insert (recordUsage) may trail after updateDoc and is
+      // irrelevant to this ordering invariant, so assert position rather than
+      // exact array equality.
+      expect(dbOps.order[0]).toBe('insert')
+      expect(dbOps.order.indexOf('updateDoc')).toBeGreaterThan(0)
 
       expect(dbOps.updatePayloads[0]).toMatchObject({
         processingStatus: 'completed',

apps/sim/lib/data-drains/sources/workflow-logs.ts

@@ -50,12 +50,18 @@ async function* pages(input: SourcePageInput): AsyncIterable<WorkflowLogRow[]> {
 
     // Heavy execution data may live in object storage; resolve pointers (bounded
     // concurrency) so the drain exports full execution data, not the slim row.
-    await mapWithConcurrency(rows, MATERIALIZE_CONCURRENCY, async (row) => {
-      row.executionData = (await materializeExecutionData(
-        row.executionData as Record<string, unknown> | null,
-        { workspaceId: row.workspaceId, workflowId: row.workflowId, executionId: row.executionId }
-      )) as WorkflowLogRow['executionData']
-    })
+    // Use the order-preserving returned array (the util's documented contract)
+    // and write back, rather than mutating rows inside the mapper.
+    const materialized = await mapWithConcurrency(rows, MATERIALIZE_CONCURRENCY, (row) =>
+      materializeExecutionData(row.executionData as Record<string, unknown> | null, {
+        workspaceId: row.workspaceId,
+        workflowId: row.workflowId,
+        executionId: row.executionId,
+      })
+    )
+    for (let i = 0; i < rows.length; i++) {
+      rows[i].executionData = materialized[i] as WorkflowLogRow['executionData']
+    }
 
     yield rows
     const last = rows[rows.length - 1]

apps/sim/lib/logs/execution/logging-session.ts

@@ -460,6 +460,7 @@ export class LoggingSession {
             totalCompletionTokens: 0,
             baseExecutionCharge: 0,
             models: {},
+            charges: {},
           }
         : calculateCostSummary(traceSpans)