Commit 61343a1
committed
fix(enrichments): address second-pass PR review
- updateWorkflowGroup output diff now keys on outputId (falling back to
blockId::path) so enrichment outputs — which share empty blockId/path —
no longer collapse to one key and drop sibling columns.
- Enrichment terminal write now clears output columns absent from the result,
so a partial/empty re-run doesn't leave stale values.
- Editing a group whose enrichment was removed from the registry shows an
explanatory panel instead of silently falling through to the new-enrichment
catalog.1 parent fb6bbd0 commit 61343a1
3 files changed
Lines changed: 37 additions & 2 deletions
File tree
- apps/sim
- app/workspace/[workspaceId]/tables/[tableId]/components/enrichments-sidebar
- background
- lib/table
Lines changed: 26 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
71 | 97 | | |
72 | 98 | | |
73 | 99 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
254 | 254 | | |
255 | 255 | | |
256 | 256 | | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
257 | 260 | | |
258 | 261 | | |
259 | 262 | | |
260 | 263 | | |
261 | | - | |
| 264 | + | |
| 265 | + | |
262 | 266 | | |
263 | 267 | | |
264 | 268 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3293 | 3293 | | |
3294 | 3294 | | |
3295 | 3295 | | |
3296 | | - | |
| 3296 | + | |
| 3297 | + | |
| 3298 | + | |
| 3299 | + | |
| 3300 | + | |
| 3301 | + | |
3297 | 3302 | | |
3298 | 3303 | | |
3299 | 3304 | | |
| |||
0 commit comments