fix(favicon): close static/ISR bake-in gap, fix manifest whitelabel leak

Addresses the third round of review findings on PR #5588:

- Cursor (Medium): generateMetadata() alone does not force per-request
  evaluation - only the overall page being dynamic does, and a plain
  process.env read is not a Next.js "dynamic signal" Next can detect.
  Verified this doesn't matter for any route TODAY (0 of 1007 real page
  routes are static/ISR-eligible - only non-HTML RSS/sitemap/robots/OG
  files are), but it was a latent gap: any future static or ISR page
  added under the root layout would silently get build-time
  (production-tier) favicon metadata baked in, with no error. Added
  `export const dynamic = 'force-dynamic'` to app/layout.tsx, matching
  the same declaration already on app/manifest.ts and
  app/api/favicon/route.ts. Verified via full build that the 9
  legitimately-static routes (RSS/sitemap/robots/OG-image files, which
  don't render through the root layout's page tree) are unaffected -
  same count, same routes, before and after.

- Greptile (P1, reported as two separate threads): app/manifest.ts
  (PWA install/home-screen icons) never checked brand.faviconUrl at
  all, so a whitelabeled deployment would still show Sim's icon when
  installed even after the HTML favicon was fixed. Now uses
  brand.faviconUrl when set, same precedence as
  generateBrandedMetadata().

- Cursor (Low): the `brand.faviconUrl ? 'production' : getDeploymentEnv()`
  ternary computed a value never actually read when brand.faviconUrl is
  set (every consumer already short-circuits on brand.faviconUrl
  first). Simplified to always resolve the environment tier.

Author: waleedlatif1

apps/sim/app/layout.tsx

@@ -24,6 +24,22 @@ export const viewport: Viewport = {
   ],
 }
 
+/**
+ * Forces every route under this layout to render dynamically. Every real page
+ * in this app already renders dynamically today (session/workspace state), so
+ * this changes nothing currently — but it's the difference between "happens
+ * to be true" and "guaranteed": {@link generateBrandedMetadata} reads
+ * `getDeploymentEnv()` for the favicon set, which depends on `process.env`
+ * being populated by `bootstrap.ts`'s runtime secrets load, and
+ * `generateMetadata()` alone does not force per-request evaluation — Next
+ * still prerenders it at build time for any route that's otherwise static or
+ * ISR-eligible. Without this, a future static/ISR page added under this
+ * layout would silently get build-time (production-tier) favicon metadata
+ * baked in, with no error. Matches the `force-dynamic` already declared on
+ * `app/manifest.ts` and `app/api/favicon/route.ts`.
+ */
+export const dynamic = 'force-dynamic'
+
 /**
  * Not a static `export const metadata` object: {@link generateBrandedMetadata}
  * reads `getDeploymentEnv()` for the favicon set, which depends on
@@ -32,7 +48,9 @@ export const viewport: Viewport = {
  * it as truly constant (eligible for build-time resolution on any
  * statically-rendered route sharing this layout) — `generateMetadata()`
  * forces the same per-request resolution `app/api/favicon/route.ts` already
- * uses.
+ * uses. Paired with the `dynamic = 'force-dynamic'` export above, which
+ * guarantees that resolution actually happens per-request rather than only
+ * "happening to" because every current page is otherwise dynamic.
  */
 export function generateMetadata(): Metadata {
   return generateBrandedMetadata()

apps/sim/app/manifest.ts

@@ -20,23 +20,28 @@ export default function manifest(): MetadataRoute.Manifest {
     background_color: '#ffffff',
     theme_color: brand.theme?.primaryColor || '#33C482',
     orientation: 'portrait-primary',
-    icons: [
-      {
-        src: '/favicon/android-chrome-192x192.png',
-        sizes: '192x192',
-        type: 'image/png',
-      },
-      {
-        src: '/favicon/android-chrome-512x512.png',
-        sizes: '512x512',
-        type: 'image/png',
-      },
-      {
-        src: '/favicon/apple-touch-icon.png',
-        sizes: '180x180',
-        type: 'image/png',
-      },
-    ],
+    // A whitelabeled deployment's install/home-screen icon should be the
+    // tenant's own brand, not Sim's — same precedence as the HTML favicon
+    // slots in generateBrandedMetadata() (ee/whitelabeling/metadata.ts).
+    icons: brand.faviconUrl
+      ? [{ src: brand.faviconUrl, sizes: 'any', type: 'image/png' }]
+      : [
+          {
+            src: '/favicon/android-chrome-192x192.png',
+            sizes: '192x192',
+            type: 'image/png',
+          },
+          {
+            src: '/favicon/android-chrome-512x512.png',
+            sizes: '512x512',
+            type: 'image/png',
+          },
+          {
+            src: '/favicon/apple-touch-icon.png',
+            sizes: '180x180',
+            type: 'image/png',
+          },
+        ],
     categories: ['productivity', 'developer', 'business'],
     shortcuts: [
       {

apps/sim/ee/whitelabeling/metadata.ts

@@ -53,11 +53,10 @@ export const ICON_SETS: Record<ReturnType<typeof getDeploymentEnv>, FaviconSet>
  */
 export function generateBrandedMetadata(override: Partial<Metadata> = {}): Metadata {
   const brand = getBrandConfig()
-  // A whitelabeled deployment's favicon slots should read as the tenant's own
-  // brand, never an internal Sim dev/staging color — fall back to production's
-  // neutral assets (matching pre-environment-favicon behavior) for the sizes
-  // `brand.faviconUrl` doesn't cover, instead of the environment-tinted set.
-  const icons = ICON_SETS[brand.faviconUrl ? 'production' : getDeploymentEnv()]
+  // Only read when brand.faviconUrl is unset — every icon/apple/shortcut slot
+  // below short-circuits on brand.faviconUrl first when it's set, so this
+  // never needs to reflect the whitelabel case.
+  const icons = ICON_SETS[getDeploymentEnv()]
 
   const defaultTitle = brand.name
   const summaryFull = `Sim is the open-source AI workspace where teams build, deploy, and manage AI agents. Connect 1,000+ integrations and every major LLM to create agents that automate real work — visually, conversationally, or with code. Trusted by over 100,000 builders — from startups to Fortune 500 companies. SOC2 compliant.`