folder fix

Author: Sg312

apps/sim/lib/copilot/generated/tool-catalog-v1.ts

@@ -439,7 +439,11 @@ export const CreateWorkflow: ToolCatalogEntry = {
   parameters: {
     type: 'object',
     properties: {
-      folderId: { type: 'string', description: 'Optional folder ID.' },
+      folderPath: {
+        type: 'string',
+        description:
+          'Optional canonical workflow-folder VFS path copied from glob("workflows/**"), for example "workflows/Dream" or "workflows/Client%20Work/Intake". Omit for the workspace root.',
+      },
       name: { type: 'string', description: 'Workflow name.' },
       workspaceId: { type: 'string', description: 'Optional workspace ID.' },
     },

apps/sim/lib/copilot/generated/tool-schemas-v1.ts

@@ -221,9 +221,10 @@ export const TOOL_RUNTIME_SCHEMAS: Record<string, ToolRuntimeSchemaEntry> = {
     parameters: {
       type: 'object',
       properties: {
-        folderId: {
+        folderPath: {
           type: 'string',
-          description: 'Optional folder ID.',
+          description:
+            'Optional canonical workflow-folder VFS path copied from glob("workflows/**"), for example "workflows/Dream" or "workflows/Client%20Work/Intake". Omit for the workspace root.',
         },
         name: {
           type: 'string',

apps/sim/lib/copilot/tools/handlers/param-types.ts

@@ -32,6 +32,9 @@ export interface GetBlockUpstreamReferencesParams {
 export interface CreateWorkflowParams {
   name?: string
   workspaceId?: string
+  /** Canonical workflow-folder VFS path, for example `workflows/Dream`. */
+  folderPath?: string
+  /** Legacy executor input. New tool calls use folderPath and resolve the ID internally. */
   folderId?: string
 }
 

apps/sim/lib/copilot/tools/handlers/workflow/mutations.test.ts

@@ -124,7 +124,7 @@ vi.mock('../access', () => ({
 
 import { applyCreateWorkflowOutputToContext } from '@/lib/copilot/request/tools/workflow-context'
 import { performUpdateWorkflow } from '@/lib/workflows/orchestration'
-import { verifyFolderWorkspace } from '@/lib/workflows/utils'
+import { listFolders, verifyFolderWorkspace } from '@/lib/workflows/utils'
 import {
   executeCreateWorkflow,
   executeMoveWorkflow,
@@ -136,6 +136,7 @@ import {
 } from './mutations'
 
 const performUpdateWorkflowMock = vi.mocked(performUpdateWorkflow)
+const listFoldersMock = vi.mocked(listFolders)
 const verifyFolderWorkspaceMock = vi.mocked(verifyFolderWorkspace)
 const billingAttribution: BillingAttributionSnapshot = {
   actorUserId: 'user-1',
@@ -291,6 +292,7 @@ describe('executeCreateWorkflow billing attribution', () => {
       payerUsage: { currentUsage: 1, limit: 10 },
     })
     reserveExecutionSlotMock.mockResolvedValue({ reserved: true, created: true })
+    listFoldersMock.mockResolvedValue([])
   })
 
   it('ignores legacy description input instead of persisting it', async () => {
@@ -320,6 +322,65 @@ describe('executeCreateWorkflow billing attribution', () => {
     })
   })
 
+  it('canonicalizes a workflow-folder VFS path and resolves its internal ID', async () => {
+    listFoldersMock.mockResolvedValue([
+      { folderId: 'folder-dream', folderName: 'Dream', parentId: null },
+      {
+        folderId: 'folder-launch-plans',
+        folderName: 'Launch Plans',
+        parentId: 'folder-dream',
+      },
+    ])
+    performCreateWorkflowMock.mockResolvedValue({
+      success: true,
+      workflow: {
+        id: 'created-workflow',
+        name: 'Created Workflow',
+        workspaceId: 'workspace-1',
+        folderId: 'folder-launch-plans',
+      },
+    })
+
+    const result = await executeCreateWorkflow(
+      {
+        name: 'Created Workflow',
+        workspaceId: 'workspace-1',
+        folderPath: 'workflows/Dream/Launch%20Plans',
+      },
+      executionContext
+    )
+
+    expect(result.success).toBe(true)
+    expect(performCreateWorkflowMock).toHaveBeenCalledWith({
+      userId: 'user-1',
+      workspaceId: 'workspace-1',
+      name: 'Created Workflow',
+      folderId: 'folder-launch-plans',
+    })
+    expect(workflowAuthzMockFns.mockAssertFolderMutable).toHaveBeenCalledWith('folder-launch-plans')
+  })
+
+  it('fails clearly when a workflow-folder VFS path does not exist', async () => {
+    listFoldersMock.mockResolvedValue([
+      { folderId: 'folder-existing', folderName: 'Existing', parentId: null },
+    ])
+
+    const result = await executeCreateWorkflow(
+      {
+        name: 'Created Workflow',
+        workspaceId: 'workspace-1',
+        folderPath: 'workflows/Dream',
+      },
+      executionContext
+    )
+
+    expect(result).toEqual({
+      success: false,
+      error: 'Folder not found at workflows/Dream',
+    })
+    expect(performCreateWorkflowMock).not.toHaveBeenCalled()
+  })
+
   it('keeps same-workspace creation and subsequent execution on the immutable payer', async () => {
     const context: ExecutionContext = { ...executionContext, workflowId: '' }
     performCreateWorkflowMock.mockResolvedValue({

apps/sim/lib/copilot/tools/handlers/workflow/mutations.ts

@@ -393,9 +393,24 @@ export async function executeCreateWorkflow(
     }
     const workspaceId =
       params?.workspaceId || context.workspaceId || (await getDefaultWorkspaceId(context.userId))
-    const folderId = params?.folderId || null
 
     await ensureWorkspaceAccess(workspaceId, context.userId, 'write')
+
+    const folderPath = typeof params?.folderPath === 'string' ? params.folderPath.trim() : ''
+    let folderId =
+      typeof params?.folderId === 'string' && params.folderId.trim() ? params.folderId.trim() : null
+    if (folderPath) {
+      const relativePath = workflowFolderRelativePath(folderPath)
+      if (!relativePath) {
+        folderId = null
+      } else {
+        folderId = lookupFolderIdByPath(folderPath, await loadFolderPathToIdMap(workspaceId))
+        if (!folderId) {
+          return { success: false, error: `Folder not found at ${folderPath}` }
+        }
+      }
+    }
+
     await assertFolderMutable(folderId)
     assertWorkflowMutationNotAborted(context)