fix(knowledge): surface connector sync dispatch failures

Author: TheodoreSpeaks

apps/sim/lib/knowledge/orchestration/connectors.test.ts

@@ -278,6 +278,33 @@ describe('performUpdateKnowledgeConnector', () => {
     })
   })
 
+  it('reports a queue failure after replacing an active connector source', async () => {
+    dbChainMockFns.limit.mockResolvedValueOnce([
+      { id: 'conn-1', connectorType: 'notion', status: 'active' },
+    ])
+    dbChainMockFns.returning.mockResolvedValueOnce([
+      { id: 'conn-1', connectorType: 'notion', status: 'active' },
+    ])
+    mockDispatchSync.mockRejectedValueOnce(new Error('queue unavailable'))
+
+    const outcome = await performUpdateKnowledgeConnector({
+      ...ACTOR,
+      knowledgeBase: KB,
+      connectorId: 'conn-1',
+      updates: { sourceConfig: { database: 'next' } },
+      resolveBillingAttribution,
+      validateSourceConfig: async () => null,
+    })
+
+    expect(outcome).toMatchObject({
+      success: false,
+      errorCode: 'internal',
+      error: 'queue unavailable',
+    })
+    expect(dbChainMockFns.update).toHaveBeenCalledOnce()
+    expect(mockDispatchSync).toHaveBeenCalledOnce()
+  })
+
   it('saves a paused connector source without synchronizing it', async () => {
     dbChainMockFns.limit.mockResolvedValueOnce([
       { id: 'conn-1', connectorType: 'notion', status: 'paused' },

apps/sim/lib/knowledge/orchestration/connectors.ts

@@ -572,16 +572,19 @@ export async function performUpdateKnowledgeConnector(
   }
 
   if (dispatchSourceSync && billingAttribution) {
-    dispatchSourceSync(connectorId, {
-      billingAttribution,
-      requestId,
-      requireRunnable: true,
-    }).catch((error) => {
-      logger.error(
-        `[${requestId}] Failed to dispatch source-change sync for connector ${connectorId}`,
-        error
+    try {
+      await dispatchSourceSync(connectorId, {
+        billingAttribution,
+        requestId,
+        requireRunnable: true,
+      })
+    } catch (error) {
+      return classifyKnowledgeFailure(
+        error,
+        requestId,
+        `Dispatch source-change sync for connector ${connectorId}`
       )
-    })
+    }
   }
 
   return { success: true, connector: withoutSecret(updated) }