fix(enrichments): address PR review feedback

- Guard the enrichment cell path on `enrichmentId` so a group typed
  'enrichment' without a registry id falls through to the workflow path
  instead of erroring.
- Clear stale output values when skipping a row for missing required inputs,
  so the auto cascade re-enriches once inputs return (was left completed+filled).
- Write a terminal state on abort in the enrichment path (matches the workflow
  path) so a cancel between run and terminal-write can't leave the cell running.
- Edit mode: apply the group update (mappings/deps/auto-run) before column
  renames so the primary edit lands even if a rename fails.
- Disable Save once validation has surfaced a missing required input.
- Use the workflowGroupById map instead of O(n) find in the context-menu and
  action-bar hot paths.

Author: TheodoreSpeaks

apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/enrichments-sidebar/enrichment-config.tsx

@@ -137,6 +137,7 @@ export function EnrichmentConfig({
     addWorkflowGroup.isPending ||
     updateWorkflowGroup.isPending ||
     updateColumn.isPending ||
+    (showValidation && missingRequired) ||
     !depsValid ||
     outputsInvalid
 
@@ -151,22 +152,23 @@ export function EnrichmentConfig({
 
     if (existingGroup) {
       try {
-        // Rename any output columns the user changed first; the rename cascades
+        // Apply the group edit (mappings / deps / auto-run) first so it lands
+        // even if a later column rename fails. Renames run after and cascade
         // into the group's output refs server-side.
-        for (const o of enrichment.outputs) {
-          const original = originalOutputName(o.id)
-          const next = (outputNames[o.id] ?? '').trim()
-          if (original && next && next !== original) {
-            await updateColumn.mutateAsync({ columnName: original, updates: { name: next } })
-          }
-        }
         await updateWorkflowGroup.mutateAsync({
           groupId: existingGroup.id,
           name: enrichment.name,
           dependencies: { columns: deps },
           inputMappings: inputMappingsList,
           autoRun,
         })
+        for (const o of enrichment.outputs) {
+          const original = originalOutputName(o.id)
+          const next = (outputNames[o.id] ?? '').trim()
+          if (original && next && next !== original) {
+            await updateColumn.mutateAsync({ columnName: original, updates: { name: next } })
+          }
+        }
         toast.success(`Updated "${enrichment.name}"`)
         onClose()
       } catch (err) {

apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx

@@ -767,8 +767,7 @@ export function TableGrid({
         typeof _exec?.jobId === 'string' &&
         _exec.jobId.startsWith('paused-')
       // Enrichment cells have no workflow execution trace to open.
-      const _isEnrichmentGroup =
-        tableWorkflowGroups.find((wg) => wg.id === _gid)?.type === 'enrichment'
+      const _isEnrichmentGroup = workflowGroupById.get(_gid)?.type === 'enrichment'
       contextMenuHasStartedRun =
         !_isEnrichmentGroup &&
         (_exec?.status === 'completed' ||
@@ -2930,8 +2929,7 @@ export function TableGrid({
       status === 'pending' && typeof exec?.jobId === 'string' && exec.jobId.startsWith('paused-')
     // Enrichment groups have no workflow execution to open — never offer "View
     // execution" for them.
-    const isEnrichmentGroup =
-      tableWorkflowGroups.find((wg) => wg.id === groupId)?.type === 'enrichment'
+    const isEnrichmentGroup = workflowGroupById.get(groupId)?.type === 'enrichment'
     return {
       rowId: row.id,
       groupId,
@@ -2940,7 +2938,7 @@ export function TableGrid({
         !isEnrichmentGroup &&
         (status === 'completed' || status === 'error' || status === 'running' || isPaused),
     }
-  }, [normalizedSelection, rows, displayColumns, tableWorkflowGroups])
+  }, [normalizedSelection, rows, displayColumns, workflowGroupById])
 
   const tableWorkflowGroupIds = useMemo(
     () => tableWorkflowGroups.map((g) => g.id),

apps/sim/background/workflow-column-execution.ts

@@ -115,8 +115,11 @@ async function runWorkflowAndWriteTerminal(
       writeWorkflowGroupState(cellCtx, { executionState, dataPatch })
 
     // Enrichment groups call a registry function directly instead of running a
-    // workflow, reusing the same pickup → run → terminal-write status flow.
-    if (group.type === 'enrichment') {
+    // workflow, reusing the same pickup → run → terminal-write status flow. The
+    // `enrichmentId` guard ensures only true registry enrichments take this path
+    // — a group typed 'enrichment' without a registry id falls through to the
+    // workflow path rather than erroring.
+    if (group.type === 'enrichment' && group.enrichmentId) {
       const { getEnrichment } = await import('@/enrichments/registry')
       const { runEnrichment } = await import('@/enrichments/run')
       const enrichment = getEnrichment(group.enrichmentId)
@@ -155,25 +158,42 @@ async function runWorkflowAndWriteTerminal(
       }
 
       // Skip (don't error) rows missing a required input — common when a table
-      // is partially filled. The cell completes empty and re-runs once the
-      // input columns fill (if they're dependencies).
+      // is partially filled. Clear any prior output values so a stale result
+      // doesn't linger (and doesn't mark the group `completed`-and-filled, which
+      // would block the auto cascade from re-enriching once inputs return).
       const isEmpty = (v: unknown) => v === undefined || v === null || v === ''
       const missingRequired = enrichment.inputs.some(
         (i) => i.required && isEmpty(enrichInputs[i.id])
       )
       if (missingRequired) {
-        await writeState({
-          status: 'completed',
-          executionId,
-          jobId: null,
-          workflowId: statusId,
-          error: null,
-        })
+        const clearPatch: RowData = {}
+        for (const out of group.outputs) {
+          if (!isEmpty(row.data[out.columnName])) clearPatch[out.columnName] = ''
+        }
+        await writeState(
+          {
+            status: 'completed',
+            executionId,
+            jobId: null,
+            workflowId: statusId,
+            error: null,
+          },
+          clearPatch
+        )
         return 'completed'
       }
 
       try {
-        if (signal?.aborted) return 'error'
+        if (signal?.aborted) {
+          await writeState({
+            status: 'error',
+            executionId,
+            jobId: null,
+            workflowId: statusId,
+            error: 'Cancelled',
+          })
+          return 'error'
+        }
         const { result, cost, error } = await runEnrichment(enrichment, enrichInputs, {
           tableId,
           rowId,
@@ -182,7 +202,16 @@ async function runWorkflowAndWriteTerminal(
         })
 
         // An abort during the cascade must not be recorded as a completed cell.
-        if (signal?.aborted) return 'error'
+        if (signal?.aborted) {
+          await writeState({
+            status: 'error',
+            executionId,
+            jobId: null,
+            workflowId: statusId,
+            error: 'Cancelled',
+          })
+          return 'error'
+        }
 
         // Every provider that ran errored (auth / rate-limit / outage) — surface
         // it rather than writing a blank cell that looks like "no data found".