do not attempt blob deletion for infra outage

Author: icecrasher321

apps/sim/lib/execution/payloads/store.test.ts

@@ -155,6 +155,25 @@ describe('large execution payload store', () => {
     expect(mockDeleteFileMetadata).not.toHaveBeenCalled()
   })
 
+  it('does not delete uploaded storage when owner metadata registration throws', async () => {
+    const value = { payload: 'x'.repeat(2048) }
+    const json = JSON.stringify(value)
+    mockRegisterLargeValueOwner.mockRejectedValueOnce(new Error('metadata db down'))
+
+    await expect(
+      storeLargeValue(value, json, Buffer.byteLength(json, 'utf8'), {
+        workspaceId: 'workspace-1',
+        workflowId: 'workflow-1',
+        executionId: 'execution-1',
+        userId: 'user-1',
+        requireDurable: true,
+      })
+    ).rejects.toThrow('metadata db down')
+
+    expect(mockDeleteFiles).not.toHaveBeenCalled()
+    expect(mockDeleteFileMetadata).not.toHaveBeenCalled()
+  })
+
   it('falls back to memory-only refs for non-durable writes when orphan cleanup fails', async () => {
     const value = { payload: 'x'.repeat(2048) }
     const json = JSON.stringify(value)

apps/sim/lib/execution/payloads/store.ts

@@ -114,27 +114,17 @@ async function registerPersistedValueOwner(
     return false
   }
 
-  try {
-    const { registerLargeValueOwner } = await import(
-      '@/lib/execution/payloads/large-value-metadata'
-    )
-    return await registerLargeValueOwner(
-      {
-        key,
-        workspaceId,
-        workflowId,
-        executionId,
-        size,
-      },
-      referencedKeys
-    )
-  } catch (error) {
-    logger.warn('Failed to register large execution value metadata', {
+  const { registerLargeValueOwner } = await import('@/lib/execution/payloads/large-value-metadata')
+  return await registerLargeValueOwner(
+    {
       key,
-      error: toError(error).message,
-    })
-    return false
-  }
+      workspaceId,
+      workflowId,
+      executionId,
+      size,
+    },
+    referencedKeys
+  )
 }
 
 async function deleteUntrackedPersistedValue(key: string): Promise<boolean> {