From 71e20dcb49168fa7d2e00f1c8fbde2d2fc5941c2 Mon Sep 17 00:00:00 2001 From: Joost de Valk Date: Tue, 15 Sep 2026 16:52:57 +0200 Subject: [PATCH] Fix manual pageview collection setting --- src/Scripts/AnalyticsScript.php | 2 +- tests/Browser/pluginSettings.spec.ts | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/Scripts/AnalyticsScript.php b/src/Scripts/AnalyticsScript.php index 8b0d5b1..b769bb9 100644 --- a/src/Scripts/AnalyticsScript.php +++ b/src/Scripts/AnalyticsScript.php @@ -27,7 +27,7 @@ public function attributes(): array 'data-mode' => Setting::boolean(SettingName::HASH_MODE) ? 'hash' : null, 'data-collect-dnt' => Setting::boolean(SettingName::COLLECT_DNT) ? 'true' : null, 'data-ignore-pages' => Setting::get(SettingName::IGNORE_PAGES), - 'data-auto-collect' => Setting::get(SettingName::MANUAL_COLLECT) ? 'true' : null, + 'data-auto-collect' => Setting::boolean(SettingName::MANUAL_COLLECT) ? 'false' : null, 'data-onload' => Setting::get(SettingName::ONLOAD_CALLBACK), 'data-sa-global' => Setting::get(SettingName::SA_GLOBAL), 'data-hostname' => Setting::get(SettingName::HOSTNAME), diff --git a/tests/Browser/pluginSettings.spec.ts b/tests/Browser/pluginSettings.spec.ts index c409661..111b852 100644 --- a/tests/Browser/pluginSettings.spec.ts +++ b/tests/Browser/pluginSettings.spec.ts @@ -180,8 +180,14 @@ test('adds a script with manually collect page views enabled', async ({ page, br await expect(page.locator('[name="simpleanalytics_manual_collect"]')).toBeChecked(); const guest = await visitAsGuest(browser); - expect(await guest.content()).toContain('data-auto-collect="true"'); + await expect(guest.locator(DEFAULT_SCRIPT_SELECTOR)).toHaveAttribute('data-auto-collect', 'false'); await guest.context().close(); + + await page.locator('[name="simpleanalytics_manual_collect"]').uncheck(); + await saveSettings(page); + const automaticGuest = await visitAsGuest(browser); + await expect(automaticGuest.locator(DEFAULT_SCRIPT_SELECTOR)).not.toHaveAttribute('data-auto-collect'); + await automaticGuest.context().close(); }); test('adds a script with overwrite domain name', async ({ page, browser }) => {