Skip to content

Commit 522e5ff

Browse files
Address review: clarify stages header and guard pull-secret cleanup
Require a defined preexistence check before deleting pull-secret.json so an early release_name failure cannot wipe a pre-populated secret. Co-authored-by: Cursor <cursoragent@cursor.com> Change-Id: Ie19b52766d0d3d6bcc0053caf3310befd57ee57c
1 parent 05e25d2 commit 522e5ff

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

‎collection/tools/roles/tools_get_openshift_release/tasks/get_openshift_release_binaries.yml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,9 @@
189189

190190
always:
191191
- name: Remove pull secret file
192-
when: _pull_secret_preexists.stat.size | default(0) == 0
192+
when:
193+
- _pull_secret_preexists is defined
194+
- _pull_secret_preexists.stat.size | default(0) == 0
193195
ansible.builtin.file:
194196
path: "{{ pull_secret_file }}"
195197
state: absent

‎jobs_definitions/adoption_verification.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
# * ADOPTION VERIFICATION *
44
#
55
# - Post-adoption verification of the shiftstack cluster.
6-
# - Runs only the verification stage to confirm the OCP-on-OSP
7-
# cluster is functional after adoption from OSP 17.1 to RHOSO 18.
6+
# - Runs the verification and openstack_test stages to confirm the
7+
# OCP-on-OSP cluster is functional after adoption from OSP 17.1 to RHOSO 18.
88
# - Skips prepare/install/post since the cluster already exists.
99
#
1010

0 commit comments

Comments
 (0)