From 84aea0451594b3e06ef23e503bcc29d87f874c2b Mon Sep 17 00:00:00 2001 From: bdchatham Date: Thu, 21 May 2026 17:04:35 -0700 Subject: [PATCH] fix(scenarios/major-upgrade): project SEI_WORKFLOW_NAME/SEI_NAMESPACE on runner Task containers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit #350 made taskruntime.LoadWorkflowIdentity mandatory at runner startup so applied SeiNodeTask CRs get a Workflow ownerRef. LoadWorkflowIdentity reads SEI_WORKFLOW_NAME + SEI_NAMESPACE from env (downward API). The keygen/provision-snd/upload-report Task containers already project these via downward API, but the 12 `runner` Task containers in scenarios/major-upgrade.yaml did NOT — pre-#350 the runner didn't need them. Result: every runner step in major-upgrade exits 2 with `seitask: infra: downward-API env not projected: [SEI_WORKFLOW_NAME SEI_NAMESPACE]` before doing any work. The gov pipeline silently failed end-to-end on the first post-#350 fire even though chaos-mesh reported the Workflow Accomplished (because chaos-mesh Accomplished doesn't mean container exit 0). Add the env block to all 12 runner Task containers. scenarios/release-test and scenarios/load-test don't invoke `runner`, so they're unaffected. Co-Authored-By: Claude Opus 4.7 (1M context) --- scenarios/major-upgrade.yaml | 108 +++++++++++++++++++++++++++++++++++ 1 file changed, 108 insertions(+) diff --git a/scenarios/major-upgrade.yaml b/scenarios/major-upgrade.yaml index 0ebab2b..5cd1a86 100644 --- a/scenarios/major-upgrade.yaml +++ b/scenarios/major-upgrade.yaml @@ -156,6 +156,15 @@ spec: - --var=FEES=10000usei - --var=GAS=500000 - --timeout=8m + env: + - name: SEI_WORKFLOW_NAME + valueFrom: + fieldRef: + fieldPath: metadata.labels['chaos-mesh.org/workflow'] + - name: SEI_NAMESPACE + valueFrom: + fieldRef: + fieldPath: metadata.namespace envFrom: - configMapRef: name: workflow-vars-major-upgrade-$SEI_WORKFLOW_RUN_ID @@ -232,6 +241,15 @@ spec: - --var=FEES=10000usei - --var=GAS=200000 - --timeout=5m + env: + - name: SEI_WORKFLOW_NAME + valueFrom: + fieldRef: + fieldPath: metadata.labels['chaos-mesh.org/workflow'] + - name: SEI_NAMESPACE + valueFrom: + fieldRef: + fieldPath: metadata.namespace envFrom: - configMapRef: name: workflow-vars-major-upgrade-$SEI_WORKFLOW_RUN_ID @@ -253,6 +271,15 @@ spec: - --var=FEES=10000usei - --var=GAS=200000 - --timeout=5m + env: + - name: SEI_WORKFLOW_NAME + valueFrom: + fieldRef: + fieldPath: metadata.labels['chaos-mesh.org/workflow'] + - name: SEI_NAMESPACE + valueFrom: + fieldRef: + fieldPath: metadata.namespace envFrom: - configMapRef: name: workflow-vars-major-upgrade-$SEI_WORKFLOW_RUN_ID @@ -274,6 +301,15 @@ spec: - --var=FEES=10000usei - --var=GAS=200000 - --timeout=5m + env: + - name: SEI_WORKFLOW_NAME + valueFrom: + fieldRef: + fieldPath: metadata.labels['chaos-mesh.org/workflow'] + - name: SEI_NAMESPACE + valueFrom: + fieldRef: + fieldPath: metadata.namespace envFrom: - configMapRef: name: workflow-vars-major-upgrade-$SEI_WORKFLOW_RUN_ID @@ -295,6 +331,15 @@ spec: - --var=FEES=10000usei - --var=GAS=200000 - --timeout=5m + env: + - name: SEI_WORKFLOW_NAME + valueFrom: + fieldRef: + fieldPath: metadata.labels['chaos-mesh.org/workflow'] + - name: SEI_NAMESPACE + valueFrom: + fieldRef: + fieldPath: metadata.namespace envFrom: - configMapRef: name: workflow-vars-major-upgrade-$SEI_WORKFLOW_RUN_ID @@ -341,6 +386,15 @@ spec: - --var=IMAGE=$SEI_POST_UPGRADE_IMG - --var=REQUIRE_PHASE=Running - --timeout=8m + env: + - name: SEI_WORKFLOW_NAME + valueFrom: + fieldRef: + fieldPath: metadata.labels['chaos-mesh.org/workflow'] + - name: SEI_NAMESPACE + valueFrom: + fieldRef: + fieldPath: metadata.namespace envFrom: - configMapRef: name: workflow-vars-major-upgrade-$SEI_WORKFLOW_RUN_ID @@ -382,6 +436,15 @@ spec: - --var=IMAGE=$SEI_POST_UPGRADE_IMG - --var=REQUIRE_PHASE=Running - --timeout=8m + env: + - name: SEI_WORKFLOW_NAME + valueFrom: + fieldRef: + fieldPath: metadata.labels['chaos-mesh.org/workflow'] + - name: SEI_NAMESPACE + valueFrom: + fieldRef: + fieldPath: metadata.namespace envFrom: - configMapRef: name: workflow-vars-major-upgrade-$SEI_WORKFLOW_RUN_ID @@ -400,6 +463,15 @@ spec: - --var=IMAGE=$SEI_POST_UPGRADE_IMG - --var=REQUIRE_PHASE=Running - --timeout=8m + env: + - name: SEI_WORKFLOW_NAME + valueFrom: + fieldRef: + fieldPath: metadata.labels['chaos-mesh.org/workflow'] + - name: SEI_NAMESPACE + valueFrom: + fieldRef: + fieldPath: metadata.namespace envFrom: - configMapRef: name: workflow-vars-major-upgrade-$SEI_WORKFLOW_RUN_ID @@ -418,6 +490,15 @@ spec: - --var=IMAGE=$SEI_POST_UPGRADE_IMG - --var=REQUIRE_PHASE=Running - --timeout=8m + env: + - name: SEI_WORKFLOW_NAME + valueFrom: + fieldRef: + fieldPath: metadata.labels['chaos-mesh.org/workflow'] + - name: SEI_NAMESPACE + valueFrom: + fieldRef: + fieldPath: metadata.namespace envFrom: - configMapRef: name: workflow-vars-major-upgrade-$SEI_WORKFLOW_RUN_ID @@ -445,6 +526,15 @@ spec: - --var=NODE=$SEI_CHAIN_ID-1 - --var=TARGET_HEIGHT=$(POST_UPGRADE_HEIGHT) - --timeout=6m + env: + - name: SEI_WORKFLOW_NAME + valueFrom: + fieldRef: + fieldPath: metadata.labels['chaos-mesh.org/workflow'] + - name: SEI_NAMESPACE + valueFrom: + fieldRef: + fieldPath: metadata.namespace envFrom: - configMapRef: name: workflow-vars-major-upgrade-$SEI_WORKFLOW_RUN_ID @@ -462,6 +552,15 @@ spec: - --var=NODE=$SEI_CHAIN_ID-2 - --var=TARGET_HEIGHT=$(POST_UPGRADE_HEIGHT) - --timeout=6m + env: + - name: SEI_WORKFLOW_NAME + valueFrom: + fieldRef: + fieldPath: metadata.labels['chaos-mesh.org/workflow'] + - name: SEI_NAMESPACE + valueFrom: + fieldRef: + fieldPath: metadata.namespace envFrom: - configMapRef: name: workflow-vars-major-upgrade-$SEI_WORKFLOW_RUN_ID @@ -479,6 +578,15 @@ spec: - --var=NODE=$SEI_CHAIN_ID-3 - --var=TARGET_HEIGHT=$(POST_UPGRADE_HEIGHT) - --timeout=6m + env: + - name: SEI_WORKFLOW_NAME + valueFrom: + fieldRef: + fieldPath: metadata.labels['chaos-mesh.org/workflow'] + - name: SEI_NAMESPACE + valueFrom: + fieldRef: + fieldPath: metadata.namespace envFrom: - configMapRef: name: workflow-vars-major-upgrade-$SEI_WORKFLOW_RUN_ID