convert debriefing editor to modeless; add focus_sexp(); fix bugs

Convert debriefing_editor_dlg from a modal stack-allocated dialog to a modeless heap-allocated dialog, matching the pattern of the briefing editor.  Update FRED infrastructure accordingly.

Add focus_sexp(int node) to debriefing_editor_dlg, mirroring the existing method in briefing_editor_dlg.  Fix both focus_sexp() implementations to search all team debriefings/briefings instead of only the currently selected team, so nodes in non-zero teams are found correctly in TVT missions.

Fix debriefing set_modified() calls to only set the flag if the debriefing data actually changes, rather than every time the editor was opened.

Author: Goober5000

fred2/briefingeditordlg.cpp

@@ -305,12 +305,12 @@ void briefing_editor_dlg::OnClose()
 	if (dup)
 		MessageBox("You have duplicate icon names.  You should resolve these.", "Warning");
 
+	FREDDoc_ptr->autosave("briefing editor");
+
 	theApp.record_window_data(&Briefing_wnd_data, this);
 	ptr = Briefing_dialog;	// this juggling prevents a crash in certain situations
-	Briefing_dialog = NULL;
+	Briefing_dialog = nullptr;
 	delete ptr;
-
-	FREDDoc_ptr->autosave("briefing editor");
 }
 
 void briefing_editor_dlg::reset_editor()

fred2/debriefingeditordlg.cpp

@@ -53,6 +53,12 @@ debriefing_editor_dlg::debriefing_editor_dlg(CWnd* pParent /*=NULL*/)
 	select_sexp_node = -1;
 }
 
+void debriefing_editor_dlg::create()
+{
+	CDialog::Create(IDD);
+	theApp.init_window(&Debriefing_wnd_data, this);
+}
+
 void debriefing_editor_dlg::DoDataExchange(CDataExchange* pDX)
 {
 	CDialog::DoDataExchange(pDX);
@@ -425,7 +431,7 @@ void debriefing_editor_dlg::OnEndlabeleditTree(NMHDR* pNMHDR, LRESULT* pResult)
 	*pResult = m_tree.end_label_edit(pTVDispInfo->item);
 }
 
-void debriefing_editor_dlg::OnClose() 
+void debriefing_editor_dlg::OnClose()
 {
 	audiostream_close_file(m_voice_id, 0);
 	m_voice_id = -1;
@@ -436,9 +442,12 @@ void debriefing_editor_dlg::OnClose()
 	Mission_music[SCORE_DEBRIEFING_AVERAGE] = m_debriefAvg_music - 1;
 	Mission_music[SCORE_DEBRIEFING_FAILURE] = m_debriefFail_music - 1;
 
-	CDialog::OnClose();
-
 	FREDDoc_ptr->autosave("debriefing editor");
+
+	theApp.record_window_data(&Debriefing_wnd_data, this);
+	debriefing_editor_dlg *ptr = Debriefing_dialog;
+	Debriefing_dialog = nullptr;
+	delete ptr;
 }
 
 void debriefing_editor_dlg::OnOK()

fred2/debriefingeditordlg.h

@@ -7,6 +7,7 @@
  *
 */
 
+#pragma once
 
 #include "mission/missionbriefcommon.h"
 
@@ -18,6 +19,7 @@ class debriefing_editor_dlg : public CDialog
 // Construction
 public:
 	void OnOK();
+	void create();
 	void update_data(int update = 1);
 	debriefing_editor_dlg(CWnd* pParent = NULL);   // standard constructor
 	int select_sexp_node;

fred2/fred.cpp

@@ -121,8 +121,9 @@ wing_editor          Wing_editor_dialog;
 waypoint_path_dlg    Waypoint_editor_dialog;
 jumpnode_dlg         Jumpnode_editor_dialog;
 music_player_dlg	 Music_player_dialog;
-bg_bitmap_dlg*       Bg_bitmap_dialog = NULL;
-briefing_editor_dlg* Briefing_dialog = NULL;
+bg_bitmap_dlg*       Bg_bitmap_dialog = nullptr;
+briefing_editor_dlg*   Briefing_dialog   = nullptr;
+debriefing_editor_dlg* Debriefing_dialog = nullptr;
 
 window_data Main_wnd_data;
 window_data Ship_wnd_data;
@@ -136,6 +137,7 @@ window_data Player_wnd_data;
 window_data Events_wnd_data;
 window_data Bg_wnd_data;
 window_data Briefing_wnd_data;
+window_data Debriefing_wnd_data;
 window_data Reinforcement_wnd_data;
 window_data Waypoint_wnd_data;
 window_data Jumpnode_wnd_data;

fred2/fred.h

@@ -17,6 +17,7 @@
 
 #include "BgBitmapDlg.h"
 #include "BriefingEditorDlg.h"
+#include "DebriefingEditorDlg.h"
 #include "resource.h"
 #include "ShipEditorDlg.h"
 #include "propdlg.h"
@@ -187,7 +188,8 @@ extern waypoint_path_dlg    Waypoint_editor_dialog; //!< The waypoint editor ins
 extern jumpnode_dlg			Jumpnode_editor_dialog; //!< The jumpnode editor instance
 extern music_player_dlg		Music_player_dialog;    //!< The music player instance
 extern bg_bitmap_dlg*       Bg_bitmap_dialog;       //!< The bitmap dialog instance
-extern briefing_editor_dlg* Briefing_dialog;        //!< The briefing editor instance
+extern briefing_editor_dlg*    Briefing_dialog;    //!< The briefing editor instance
+extern debriefing_editor_dlg*  Debriefing_dialog;  //!< The debriefing editor instance
 
 extern CFREDApp theApp; //!< The application instance
 
@@ -203,6 +205,7 @@ extern window_data Player_wnd_data;
 extern window_data Events_wnd_data;
 extern window_data Bg_wnd_data;
 extern window_data Briefing_wnd_data;
+extern window_data Debriefing_wnd_data;
 extern window_data Reinforcement_wnd_data;
 extern window_data Waypoint_wnd_data;
 extern window_data Jumpnode_wnd_data;

fred2/fredview.cpp

@@ -4213,9 +4213,14 @@ void CFREDView::OnEditorsBriefing()
 
 void CFREDView::OnEditorsDebriefing() 
 {
-	debriefing_editor_dlg dlg;
+	if (!Debriefing_dialog) {
+		Debriefing_dialog = new debriefing_editor_dlg;
+		Debriefing_dialog->create();
+	}
 
-	dlg.DoModal();
+	Debriefing_dialog->SetWindowPos(&wndTop, 0, 0, 0, 0,
+		SWP_SHOWWINDOW | SWP_NOMOVE | SWP_NOSIZE);
+	Debriefing_dialog->ShowWindow(SW_RESTORE);
 }
 
 void CFREDView::OnSaveCamera() 

fred2/management.cpp

@@ -2283,10 +2283,15 @@ int sexp_reference_handler(int node, sexp_src source, int source_index, char *ms
 		}
 
 		case sexp_src::DEBRIEFING: {
-			debriefing_editor_dlg dlg;
+			if (!Debriefing_dialog) {
+				Debriefing_dialog = new debriefing_editor_dlg;
+				Debriefing_dialog->create();
+			}
 
-			dlg.select_sexp_node = node;
-			dlg.DoModal();
+			Debriefing_dialog->SetWindowPos(&CWnd::wndTop, 0, 0, 0, 0,
+				SWP_SHOWWINDOW | SWP_NOMOVE | SWP_NOSIZE);
+			Debriefing_dialog->ShowWindow(SW_RESTORE);
+			Debriefing_dialog->focus_sexp(node);
 			break;
 		}