From 81d6757c37ec05877aa945784343366fe7339881 Mon Sep 17 00:00:00 2001
From: Thomas Jung <thomas.jung@sap.com>
Date: Fri, 6 Nov 2026 14:14:31 -0500
Subject: [PATCH] fix(ci): inline parser JSON + copy tut-alert partial in
 option-tail-leak test
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Follow-up after the first round fixed B/C/E but left A and D red.

A (5 srv-qa suites, 'Cannot find module ./icon-allowlist.json'):
  directives/ui.ts and reference-links.ts loaded icon-allowlist.json /
  api-libs.json via createRequire('./x.json') at runtime, but neither
  parsers bundle (srv-qa/lib + srv/lib/_shared, both built from
  scripts/parsers/*) ships the JSON beside the .mjs, so the runtime require
  fails. Switch to static default JSON imports (tsconfig has
  resolveJsonModule) — esbuild/vite/tsx all inline the JSON into the bundle,
  removing the sidecar-file dependency for BOTH bundles and also removing the
  createRequire imports that caused the earlier banner collision.

D (option-tail-leak.test.ts, 'Hugo build failed exit 1'):
  render-blockquote.html now delegates  alerts to the tut-alert
  partial (#2595/#71a8d70bc), but the test's temp Hugo site never copied
  tut-alert.html, so  was unresolvable and the
  build died. Copy tut-alert.html into the temp layouts/partials/ dir.
  Verified by reproducing the real Hugo pipeline: build now exits 0 and
  renders exactly 2 <aside class="alert alert-tip">.
---
 scripts/parsers/directives/reference-links.ts | 8 ++++----
 scripts/parsers/directives/ui.ts              | 6 ++----
 test/unit/option-tail-leak.test.ts            | 6 ++++++
 3 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/scripts/parsers/directives/reference-links.ts b/scripts/parsers/directives/reference-links.ts
index 7f3123e2e..eef527a18 100644
--- a/scripts/parsers/directives/reference-links.ts
+++ b/scripts/parsers/directives/reference-links.ts
@@ -17,14 +17,14 @@
 // node.label is non-empty. Directives that need a computed display label mutate
 // node.label in their expand hook; render() then omits `label` from output.params.
 
-import { createRequire } from 'module';
 import type { DirectiveDef, DirectiveRenderOutput } from '../directive-registry.js';
 import { DirectiveParseError } from '../directives.js';
 import type { DirectiveNode, ExpandDirectivesContext } from '../directives.js';
+import apiLibsJson from './api-libs.json';
 
-// Load api-libs.json at module init time
-const _require = createRequire(import.meta.url);
-const API_LIBS: Record<string, string> = _require('./api-libs.json');
+// api-libs.json is inlined at bundle time (static JSON import) so no sidecar
+// file is needed next to the built parsers.bundle.mjs.
+const API_LIBS: Record<string, string> = apiLibsJson as Record<string, string>;
 
 // ─── :tutorial-ref[slug]{label?} ─────────────────────────────────────────────
 //
diff --git a/scripts/parsers/directives/ui.ts b/scripts/parsers/directives/ui.ts
index 3e30e1ac4..a44e71841 100644
--- a/scripts/parsers/directives/ui.ts
+++ b/scripts/parsers/directives/ui.ts
@@ -10,14 +10,12 @@
 // Side-effect: call registerUiDirectives() once at startup.
 // In tests: resetRegistry(); registerUiDirectives()
 
-import { createRequire } from 'node:module';
 import { registerDirective, getRegistry } from '../directive-registry.js';
 import { DirectiveParseError } from '../directives.js';
 import type { DirectiveNode } from '../directives.js';
+import iconAllowlistJson from './icon-allowlist.json';
 
-const _require = createRequire(import.meta.url);
-// eslint-disable-next-line @typescript-eslint/no-var-requires
-const iconAllowlist: string[] = _require('./icon-allowlist.json') as string[];
+const iconAllowlist: string[] = iconAllowlistJson as string[];
 
 // ─── Key token constants ──────────────────────────────────────────────────────
 
diff --git a/test/unit/option-tail-leak.test.ts b/test/unit/option-tail-leak.test.ts
index c17c26ccb..308a1f355 100644
--- a/test/unit/option-tail-leak.test.ts
+++ b/test/unit/option-tail-leak.test.ts
@@ -36,6 +36,7 @@ const __dirname = dirname(fileURLToPath(import.meta.url));
 const REPO_ROOT = join(__dirname, '..', '..');
 const SHORTCODES = join(REPO_ROOT, 'hugo', 'layouts', 'shortcodes');
 const MARKUP = join(REPO_ROOT, 'hugo', 'layouts', '_default', '_markup');
+const PARTIALS = join(REPO_ROOT, 'hugo', 'layouts', 'partials');
 
 function hugoBinary(): string {
   return process.env.HUGO || 'hugo';
@@ -51,6 +52,7 @@ function renderThroughPipeline(stepBody: string): string {
   const dir = mkdtempSync(join(tmpdir(), 'opt-tail-leak-'));
   mkdirSync(join(dir, 'layouts', 'shortcodes'), { recursive: true });
   mkdirSync(join(dir, 'layouts', '_default', '_markup'), { recursive: true });
+  mkdirSync(join(dir, 'layouts', 'partials'), { recursive: true });
   mkdirSync(join(dir, 'content'), { recursive: true });
 
   for (const sc of ['os-options.html', 'os-panel.html', 'option-tabs.html', 'tab.html']) {
@@ -67,6 +69,10 @@ function renderThroughPipeline(stepBody: string): string {
     const p = join(MARKUP, h);
     if (existsSync(p)) copyFileSync(p, join(dir, 'layouts', '_default', '_markup', h));
   }
+  // render-blockquote.html delegates GitHub-style alerts (`> [!TIP]`) to the
+  // tut-alert partial (#2595/#71a8d70bc), so it must be present or the Hugo
+  // build fails resolving `partial "tut-alert.html"`.
+  copyFileSync(join(PARTIALS, 'tut-alert.html'), join(dir, 'layouts', 'partials', 'tut-alert.html'));
 
   writeFileSync(join(dir, 'hugo.toml'),
     'baseURL = "http://example.org/"\n' +