From c88100f6bcce4b373a42c54511058c9e46a4cdb3 Mon Sep 17 00:00:00 2001 From: akzarma <25038017+akzarma@users.noreply.github.com> Date: Sat, 21 Nov 2026 16:39:05 +0530 Subject: [PATCH] fix: preserve debug output when repr raises --- devtools/debug.py | 6 +++++- tests/test_main.py | 13 +++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/devtools/debug.py b/devtools/debug.py index d7e471c..a8eb908 100644 --- a/devtools/debug.py +++ b/devtools/debug.py @@ -50,7 +50,11 @@ def str(self, highlight: bool = False) -> StrType: s += pformat(self.value, indent=4, highlight=highlight) except Exception as exc: v = sformat(f'!!! error pretty printing value: {exc!r}', sformat.yellow, apply=highlight) - s += f'{self.value!r}{suffix}\n {v}' + try: + fallback = repr(self.value) + except Exception: + fallback = '' + s += f'{fallback}{suffix}\n {v}' else: s += suffix return s diff --git a/tests/test_main.py b/tests/test_main.py index deab352..0f58539 100644 --- a/tests/test_main.py +++ b/tests/test_main.py @@ -310,6 +310,19 @@ def __getattr__(self, item: str) -> None: ) +def test_debug_when_repr_raises(capsys: pytest.CaptureFixture[str]): + class ClosedResource: + def __repr__(self) -> str: + raise RuntimeError('resource is closed') + + resource = ClosedResource() + assert debug(resource) is resource + stdout, stderr = capsys.readouterr() + assert ' (ClosedResource)' in stdout + assert "!!! error pretty printing value: RuntimeError('resource is closed')" in stdout + assert stderr == '' + + def test_multiple_debugs(): debug.format([i * 2 for i in range(2)]) debug.format([i * 2 for i in range(2)])