Skip to content

Commit 71900c5

Browse files
committed
fix(ci): preserve compatible registry dependency versions
1 parent 37bf8c8 commit 71900c5

3 files changed

Lines changed: 5 additions & 54 deletions

File tree

scripts/publish_crates.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import os
55
import re
66
import subprocess
7-
import sys
87
import time
98
import tomllib
109
import urllib.error
@@ -121,14 +120,6 @@ def crate_exists(package: str, version: str) -> bool:
121120
raise
122121

123122

124-
def refresh_registry_lock(root: Path, package: str, version: str) -> None:
125-
subprocess.run(
126-
[sys.executable, "scripts/refresh_publish_lock.py", package, version],
127-
cwd=root,
128-
check=True,
129-
)
130-
131-
132123
def publish_package(root: Path, package: str, version: str) -> None:
133124
for attempt in range(1, 19):
134125
print(f"publishing {package} {version}, attempt {attempt}", flush=True)
@@ -183,8 +174,6 @@ def main() -> None:
183174
if crate_exists(package, version):
184175
print(f"{package} {version} already published; skipping", flush=True)
185176
continue
186-
if package == "pd-vm":
187-
refresh_registry_lock(root, "pd-host-function", args.host_version)
188177
publish_package(root, package, version)
189178

190179

scripts/refresh_publish_lock.py

Lines changed: 0 additions & 43 deletions
This file was deleted.

scripts/test_publish_crates.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@ def test_workflow_supports_unyank_and_explicit_recovery_publish_tags(self) -> No
1616
self.assertIn("'publish-crates-*-host-*'", workflow)
1717
self.assertIn('publish_spec="${GITHUB_REF_NAME#publish-crates-}"', workflow)
1818

19+
def test_publish_script_does_not_force_registry_lock_versions(self) -> None:
20+
source = (Path(__file__).parent / "publish_crates.py").read_text()
21+
self.assertNotIn("refresh_registry_lock", source)
22+
self.assertNotIn("refresh_publish_lock.py", source)
23+
1924
def test_package_versions_keep_host_macro_on_compatible_line(self) -> None:
2025
self.assertEqual(
2126
publish_crates.package_versions("0.23.1", "0.22.7"),

0 commit comments

Comments
 (0)