diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 83fc314107..40c7968c5d 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -158,20 +158,11 @@ jobs: TARGET: ${{ matrix.target }} BUILD_PROFILE: ${{ matrix.mode }} run: bash ci/run.bash - - name: Run cargo check - if: matrix.mode != 'release' - env: - TARGET: ${{ matrix.target }} - # os-specific code leads to lints escaping if we only run this in one target - run: | - cargo check --all --all-targets --features test - git -c core.quotePath=false ls-files -- '*.rs' | ForEach-Object { - (Get-Item -LiteralPath $_).LastWriteTime = Get-Date - } - name: Run cargo clippy if: matrix.mode != 'release' && matrix.mingwdir == '' env: TARGET: ${{ matrix.target }} + # os-specific code leads to lints escaping if we only run this in one target run: | rustup component add clippy cargo clippy --all-targets --all-features -- -D warnings @@ -358,20 +349,11 @@ jobs: TARGET: ${{ matrix.target }} BUILD_PROFILE: ${{ matrix.mode }} run: bash ci/run.bash - - name: Run cargo check - if: matrix.mode != 'release' - env: - TARGET: ${{ matrix.target }} - # os-specific code leads to lints escaping if we only run this in one target - run: | - cargo check --all --all-targets --features test - git -c core.quotePath=false ls-files -- '*.rs' | ForEach-Object { - (Get-Item -LiteralPath $_).LastWriteTime = Get-Date - } - name: Run cargo clippy if: matrix.mode != 'release' && matrix.mingwdir == '' env: TARGET: ${{ matrix.target }} + # os-specific code leads to lints escaping if we only run this in one target run: | rustup component add clippy cargo clippy --all-targets --all-features -- -D warnings @@ -564,20 +546,11 @@ jobs: TARGET: ${{ matrix.target }} BUILD_PROFILE: ${{ matrix.mode }} run: bash ci/run.bash - - name: Run cargo check - if: matrix.mode != 'release' - env: - TARGET: ${{ matrix.target }} - # os-specific code leads to lints escaping if we only run this in one target - run: | - cargo check --all --all-targets --features test - git -c core.quotePath=false ls-files -- '*.rs' | ForEach-Object { - (Get-Item -LiteralPath $_).LastWriteTime = Get-Date - } - name: Run cargo clippy if: matrix.mode != 'release' && matrix.mingwdir == '' env: TARGET: ${{ matrix.target }} + # os-specific code leads to lints escaping if we only run this in one target run: | rustup component add clippy cargo clippy --all-targets --all-features -- -D warnings @@ -1580,10 +1553,8 @@ jobs: run: | rustup toolchain install nightly --profile=minimal -c=rustfmt cargo +nightly xfmt --check - - name: Run cargo check and clippy + - name: Run cargo clippy run: | - cargo check --all --all-targets --features test - git ls-files -- '*.rs' | xargs touch cargo clippy --all-targets --all-features -- -D warnings # This is ci/actions-templates/all-features-template.yaml # Do not edit this file in .github/workflows diff --git a/ci/actions-templates/centos-fmt-clippy-template.yaml b/ci/actions-templates/centos-fmt-clippy-template.yaml index aae264f749..05703ba318 100644 --- a/ci/actions-templates/centos-fmt-clippy-template.yaml +++ b/ci/actions-templates/centos-fmt-clippy-template.yaml @@ -80,8 +80,6 @@ jobs: # skip-all run: | rustup toolchain install nightly --profile=minimal -c=rustfmt cargo +nightly xfmt --check - - name: Run cargo check and clippy + - name: Run cargo clippy run: | - cargo check --all --all-targets --features test - git ls-files -- '*.rs' | xargs touch cargo clippy --all-targets --all-features -- -D warnings diff --git a/ci/actions-templates/windows-builds-template.yaml b/ci/actions-templates/windows-builds-template.yaml index 387e17b80a..3ac3107828 100644 --- a/ci/actions-templates/windows-builds-template.yaml +++ b/ci/actions-templates/windows-builds-template.yaml @@ -149,20 +149,11 @@ jobs: # skip-main skip-pr skip-stable TARGET: ${{ matrix.target }} BUILD_PROFILE: ${{ matrix.mode }} run: bash ci/run.bash - - name: Run cargo check - if: matrix.mode != 'release' - env: - TARGET: ${{ matrix.target }} - # os-specific code leads to lints escaping if we only run this in one target - run: | - cargo check --all --all-targets --features test - git -c core.quotePath=false ls-files -- '*.rs' | ForEach-Object { - (Get-Item -LiteralPath $_).LastWriteTime = Get-Date - } - name: Run cargo clippy if: matrix.mode != 'release' && matrix.mingwdir == '' env: TARGET: ${{ matrix.target }} + # os-specific code leads to lints escaping if we only run this in one target run: | rustup component add clippy cargo clippy --all-targets --all-features -- -D warnings