https://github.com/rust-lang/rust/pull/125752/files would add drop bomps to command wrappers that forces the test writer to check command exit status. However, some rmake.rs tests use raw Command invocations for various reasons, and it's super easy to forget to check for command exit status.
We should probably:
- Convert
Command invocations to command wrappers where reasonable.
- Introduce something to force a check of the exit status if for some reason a raw
Command cannot be converted into a command wrapper.
https://github.com/rust-lang/rust/pull/125752/files would add drop bomps to command wrappers that forces the test writer to check command exit status. However, some rmake.rs tests use raw
Commandinvocations for various reasons, and it's super easy to forget to check for command exit status.We should probably:
Commandinvocations to command wrappers where reasonable.Commandcannot be converted into a command wrapper.