Type discrepancies between corepc and v30 blockchain module.

[satsfy]

Hi! I manually inspected the types for every call in blockchain module compared to v30. I found some errors. Here is a report of what I found:

• dumptxoutset
• getbestblockhash
• getblock: The RPC has 4 distinct verbose return types, only 2 of which are implemented.
• getblockchaininfo
• getblockcount
• getblockfilter
• getblockfrompeer
• getblockhash
• getblockheader
• getblockstats
• getchainstates
• getchaintips
• getchaintxstats
• getdeploymentinfo: The getdeploymentinfo RPC blockhash argument is optional. If omitted, it queries the blockchain tip.
• getdescriptoractivity: Bitcoin Core v30 marks the blockhashes and scanobjects arguments of getdescriptoractivity RPC as required, instead of failing with a JSON parsing error when omitted.
• getdifficulty
• getmempoolancestors
• getmempooldescendants
• getmempoolentry
• getmempoolinfo
• getrawmempool: When getrawmempool RPC is called with optional verbose argument set to false and subsequent mempool_sequence set to true, a distinct type is returned from v21 onward to v30.
• gettxoutproof
• gettxoutsetinfo: The RPC has missing fields which are enabled only when coinstatsindex option is called or muhash hash type is used.
• gettxspendingprevout
• importmempool
• preciousblock
• pruneblockchain
• savemempool
• scanblocks: From v26 onward, the return type of scanblocks RPC has an argument called completed.
• verifychain
• verifytxoutproof
• estimaterawfee: The conf_target argument only takes in values from 1 to 1008 inclusive. All values outside these ranges return an error.
• waitforblock
• waitforblockheight
• waitfornewblock

[jamillambert]

Nice one man! Looks like you have done a lot of work on it. I'm just about to stop work for the day, but will have a proper look on Monday.

[jamillambert]

In general the PRs all look really good. I have just gone through them all and made a few comments.