From 1aad598001ec97965bd443d91e3b122564ac77fe Mon Sep 17 00:00:00 2001 From: Douglas Eichelberger Date: Tue, 29 Sep 2026 14:10:17 -0700 Subject: [PATCH] Raise the minimum VS Code version to 1.110 @types/vscode is ^1.110.0, and vsce won't package an extension whose engines.vscode allows older versions than the API it compiles against, so packaging failed with engines.vscode at ^1.67.0. Packaging also failed because package.json had a files list alongside the .vscodeignore from the original yo code scaffold, and vsce won't combine the two. This keeps the files allowlist, narrowed to the bundle, CHANGELOG and LICENSE (vsce adds package.json and the README itself), and drops .vscodeignore. The README's relative image link is rewritten to the GitHub URL, so images/ doesn't need to ship. npx vsce package now produces a 7-file, 20 KB .vsix. --- .vscodeignore | 13 ------------- CHANGELOG.md | 2 ++ package-lock.json | 2 +- package.json | 6 ++++-- 4 files changed, 7 insertions(+), 16 deletions(-) delete mode 100644 .vscodeignore diff --git a/.vscodeignore b/.vscodeignore deleted file mode 100644 index c613679..0000000 --- a/.vscodeignore +++ /dev/null @@ -1,13 +0,0 @@ -.vscode/** -.vscode-test/** -out/** -node_modules/** -src/** -.gitignore -.yarnrc -webpack.config.js -vsc-extension-quickstart.md -**/tsconfig.json -**/.eslintrc.json -**/*.map -**/*.ts diff --git a/CHANGELOG.md b/CHANGELOG.md index 01dfc17..b5939ea 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,8 @@ Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how ## [Unreleased] +- Requires VS Code 1.110 or later, matching the `@types/vscode` version the extension is built against. + ## [0.0.7] - 2022-07-25 - When the ownership status bar item indicates an error, clicking on the status bar item will show the extension's Output Channel. diff --git a/package-lock.json b/package-lock.json index 45940a1..c045271 100644 --- a/package-lock.json +++ b/package-lock.json @@ -34,7 +34,7 @@ "webpack-cli": "^7.0.2" }, "engines": { - "vscode": "^1.67.0" + "vscode": "^1.110.0" } }, "node_modules/@azure/abort-controller": { diff --git a/package.json b/package.json index be52cbf..2286c18 100644 --- a/package.json +++ b/package.json @@ -5,7 +5,7 @@ "displayName": "Code Ownership for VSCode", "description": "VSCode extension Big Rails Code Ownership", "engines": { - "vscode": "^1.67.0" + "vscode": "^1.110.0" }, "categories": [ "Other" @@ -56,7 +56,9 @@ "keywords": [], "author": "", "files": [ - "dist" + "dist/extension.js", + "CHANGELOG.md", + "LICENSE" ], "private": true, "devDependencies": {