From 06379c3d54cce9c9d3a3be50298685bcb29c27b6 Mon Sep 17 00:00:00 2001 From: Akira Matsuda Date: Mon, 5 Jan 2026 02:37:49 +0900 Subject: [PATCH 1/4] Fix failing test The test was expecting CRLF but the Mail gem's body.decoded returns LF since the heredoc input uses Unix line endings. --- test/models/message_test.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/models/message_test.rb b/test/models/message_test.rb index 9149ee8..c1bdb78 100644 --- a/test/models/message_test.rb +++ b/test/models/message_test.rb @@ -10,7 +10,7 @@ class MessageTest < ActiveSupport::TestCase Hello, world! END_OF_BODY m = Message.from_mail(mail, List.find_by_name('ruby-list'), 1) - assert_equal "Hello, world!\r\n", m.body + assert_equal "Hello, world!\n", m.body assert_equal DateTime.parse('2005-12-15T19:32:40+09:00'), m.published_at end From 23bd416227b7586fdbfa884a8a2a52669feac0a6 Mon Sep 17 00:00:00 2001 From: Akira Matsuda Date: Mon, 5 Jan 2026 03:55:27 +0900 Subject: [PATCH 2/4] Missing yyyymm values fox fixture data --- test/fixtures/messages.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/fixtures/messages.yml b/test/fixtures/messages.yml index 853db18..13f4ab0 100644 --- a/test/fixtures/messages.yml +++ b/test/fixtures/messages.yml @@ -7,6 +7,7 @@ message1: list_id: 1 list_seq: 123 published_at: 1995-12-21 05:44:05 + yyyymm: 199512 message2: subject: Mail2 @@ -15,3 +16,4 @@ message2: list_id: 2 list_seq: 234 published_at: 1997-07-28 14:51:40 + yyyymm: 199707 From 8f5e0b3005e2510b05aa073b8dfeb4b17e4b0c1e Mon Sep 17 00:00:00 2001 From: Akira Matsuda Date: Mon, 5 Jan 2026 03:58:13 +0900 Subject: [PATCH 3/4] Fix test schenario to follow actual page trnsitions --- test/system/messages_test.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/system/messages_test.rb b/test/system/messages_test.rb index 62eefec..0302957 100644 --- a/test/system/messages_test.rb +++ b/test/system/messages_test.rb @@ -17,8 +17,8 @@ class MessagesTest < ApplicationSystemTestCase end test 'visiting the search page, and searching a message' do - visit root_url - assert_selector "h1", text: "blade.ruby-lang.org" + visit '/ruby-list' # message1 is in ruby-list + assert_selector 'h1', text: 'ruby-list' fill_in :q, with: @message1.body click_button 'Search' From 5332dea6bd425332f1e34078e20dfe8252527cef Mon Sep 17 00:00:00 2001 From: Akira Matsuda Date: Mon, 5 Jan 2026 04:47:52 +0900 Subject: [PATCH 4/4] Don't convert nil to 0 when the given yyyymm was nil --- app/controllers/messages_controller.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/controllers/messages_controller.rb b/app/controllers/messages_controller.rb index 70578e2..38e843a 100644 --- a/app/controllers/messages_controller.rb +++ b/app/controllers/messages_controller.rb @@ -3,7 +3,7 @@ class MessagesController < ApplicationController # GET /ruby-dev def index(list_name: nil, yyyymm: nil, q: nil) - yyyymm = yyyymm.to_i + yyyymm = yyyymm&.to_i if list_name @list = List.find_by_name list_name