From d84f6fee22b771bdb40ac01a3d25ebf7176e0c32 Mon Sep 17 00:00:00 2001 From: ferdymercury Date: Tue, 15 Sep 2026 11:57:29 +0200 Subject: [PATCH 1/6] [ci] Add Debian testing It's like Debian13, but tests the new libcivetweb-dev package, so builtin_civetweb can be OFF. [ci] disable pyspark on Debiantesting CMake Error at cmake/modules/FindPySpark.cmake:34 (message): Currently, there are no Spark versions that support Java version greater than 21. Found Java version 25.0.4.1. Call Stack (most recent call first): cmake/modules/SearchInstalledSoftware.cmake:1259 (find_package) CMakeLists.txt:131 (include) --- .github/workflows/root-ci-config/buildconfig/debiantesting.txt | 2 ++ .github/workflows/root-ci.yml | 1 + 2 files changed, 3 insertions(+) create mode 100644 .github/workflows/root-ci-config/buildconfig/debiantesting.txt diff --git a/.github/workflows/root-ci-config/buildconfig/debiantesting.txt b/.github/workflows/root-ci-config/buildconfig/debiantesting.txt new file mode 100644 index 0000000000000..425074e32fc19 --- /dev/null +++ b/.github/workflows/root-ci-config/buildconfig/debiantesting.txt @@ -0,0 +1,2 @@ +CMAKE_CXX_STANDARD=23 +test_distrdf_pyspark=OFF diff --git a/.github/workflows/root-ci.yml b/.github/workflows/root-ci.yml index 0af636192a117..e192c6b5eae9e 100644 --- a/.github/workflows/root-ci.yml +++ b/.github/workflows/root-ci.yml @@ -414,6 +414,7 @@ jobs: - image: ubuntu2610 - image: debian13 overrides: ["dev=ON", "CMAKE_CXX_FLAGS=-Wsuggest-override"] + - image: debiantesting # Special builds - image: alma9 platform_config: alma9-modules_off From 615732d884a5325c78ee07218a907c24fa061455 Mon Sep 17 00:00:00 2001 From: ferdymercury Date: Tue, 15 Sep 2026 17:09:23 +0200 Subject: [PATCH 2/6] [ci] debiantesting: test builtin_llvm=OFF --- .github/workflows/root-ci-config/buildconfig/debiantesting.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/root-ci-config/buildconfig/debiantesting.txt b/.github/workflows/root-ci-config/buildconfig/debiantesting.txt index 425074e32fc19..da54647e3f3a6 100644 --- a/.github/workflows/root-ci-config/buildconfig/debiantesting.txt +++ b/.github/workflows/root-ci-config/buildconfig/debiantesting.txt @@ -1,2 +1,3 @@ CMAKE_CXX_STANDARD=23 +builtin_llvm=OFF test_distrdf_pyspark=OFF From bbe23c7d8ce57cda3e951360c7922c7769f019b6 Mon Sep 17 00:00:00 2001 From: ferdymercury Date: Tue, 22 Sep 2026 12:45:18 +0200 Subject: [PATCH 3/6] g++16 workaround for lost operator == issue in ROOT rror: /github/home/ROOT-CI/src/roottest/root/tree/selectorreader/runCollections.C:169:37: error: invalid operands to binary expression ('iterator' (aka '__gnu_cxx::__normal_iterator, std::allocator > *, vector, std::allocator >, std::allocator, std::allocator > > > >') and 'iterator') for (std::string const &treeName : trees) ^ /github/home/ROOT-CI/build/include/TString.h:56:9: note: candidate function not viable: no known conversion from 'iterator' (aka '__gnu_cxx::__normal_iterator, std::allocator > *, vector, std::allocator >, std::allocator, std::allocator > > > >') to 'const TString' for 1st argument Bool_t operator==(const TString &s1, const char *s2); ^ ~~~~~~~~~~~~~~~~~ --- roottest/root/meta/genreflex/TClass/TClassUtils.h | 9 +++++---- roottest/root/tree/selectorreader/runClasses.C | 4 ++-- roottest/root/tree/selectorreader/runCollections.C | 4 ++-- 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/roottest/root/meta/genreflex/TClass/TClassUtils.h b/roottest/root/meta/genreflex/TClass/TClassUtils.h index a0571313a8912..1d05f802cc2a0 100644 --- a/roottest/root/meta/genreflex/TClass/TClassUtils.h +++ b/roottest/root/meta/genreflex/TClass/TClassUtils.h @@ -51,10 +51,11 @@ void printMemberNames(const std::string& className, const std::string indent="", std::cout << std::endl; if (mbProp.count(dmName)!=0){ TDictAttributeMap* attrMap = dm->GetAttributeMap(); - for (propertiesNames::iterator prop=mbProp[dmName].begin(); - prop!=mbProp[dmName].end();prop++){ - const char* propVals = attrMap->GetPropertyAsString(prop->c_str()); - std::cout << " - " << *prop << ": " << propVals << std::endl; + propertiesNames &props = mbProp[dmName]; + for (size_t i = 0; i < props.size(); ++i) { + const std::string &prop = props[i]; + const char* propVals = attrMap->GetPropertyAsString(prop.c_str()); + std::cout << " - " << prop << ": " << propVals << std::endl; } } } diff --git a/roottest/root/tree/selectorreader/runClasses.C b/roottest/root/tree/selectorreader/runClasses.C index 912dc429736fc..741c1e58e4b7f 100644 --- a/roottest/root/tree/selectorreader/runClasses.C +++ b/roottest/root/tree/selectorreader/runClasses.C @@ -124,8 +124,8 @@ void runClasses(const std::string &srcdir = ".") { "TreeEventTreeSimple2", "TreeDuplicateName" }; - for (std::string const &treeName : trees) - { + for (size_t i = 0; i < trees.size(); ++i) { + std::string const &treeName = trees[i]; fprintf(stderr, "Testing tree %s\n", treeName.c_str()); TFile f((srcdir + "/trees/" + treeName + ".root").c_str()); // Load file diff --git a/roottest/root/tree/selectorreader/runCollections.C b/roottest/root/tree/selectorreader/runCollections.C index bbe96c09a727c..21956ecc60600 100644 --- a/roottest/root/tree/selectorreader/runCollections.C +++ b/roottest/root/tree/selectorreader/runCollections.C @@ -166,8 +166,8 @@ void runCollections(const std::string &srcdir = ".") //"TreeTClonesArray0", // Known failure "TreeTClonesArray2" }; - for (std::string const &treeName : trees) - { + for (size_t i = 0; i < trees.size(); ++i) { + std::string const &treeName = trees[i]; fprintf(stderr, "Testing tree %s\n", treeName.c_str()); TFile f((srcdir + "/trees/" + treeName + ".root").c_str()); // Load file From aef1df66f0894e2c42f705dec15ee4e5a92c6251 Mon Sep 17 00:00:00 2001 From: ferdymercury Date: Tue, 29 Sep 2026 15:56:44 +0200 Subject: [PATCH 4/6] use system mathtext --- .github/workflows/root-ci-config/buildconfig/debiantesting.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/root-ci-config/buildconfig/debiantesting.txt b/.github/workflows/root-ci-config/buildconfig/debiantesting.txt index da54647e3f3a6..896845d08f734 100644 --- a/.github/workflows/root-ci-config/buildconfig/debiantesting.txt +++ b/.github/workflows/root-ci-config/buildconfig/debiantesting.txt @@ -1,3 +1,4 @@ CMAKE_CXX_STANDARD=23 builtin_llvm=OFF +builtin_mathtext=OFF test_distrdf_pyspark=OFF From 3b452ce80349ca99c0c6a669b92e63a625cb7155 Mon Sep 17 00:00:00 2001 From: ferdymercury Date: Tue, 22 Sep 2026 14:39:32 +0200 Subject: [PATCH 5/6] [ci] debiantesting with Release do not use debug build type TODO: proper fix would be to skip adding this flag into Cling based on ifdef buildtype Unknown command line argument '-optimize-regalloc=0'. Try: 'cling (LLVM option parsing) --help'2026-09-30T15:00:08.7528489Z cling (LLVM option parsing): Did you mean '--vp-static-alloc=0'? --- .github/workflows/root-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/root-ci.yml b/.github/workflows/root-ci.yml index e192c6b5eae9e..f362b1c8a58be 100644 --- a/.github/workflows/root-ci.yml +++ b/.github/workflows/root-ci.yml @@ -415,6 +415,7 @@ jobs: - image: debian13 overrides: ["dev=ON", "CMAKE_CXX_FLAGS=-Wsuggest-override"] - image: debiantesting + overrides: ["CMAKE_BUILD_TYPE=Release"] # Special builds - image: alma9 platform_config: alma9-modules_off From 86ff2184f6b7f5035e064a3624a6cacb9fdfcd8a Mon Sep 17 00:00:00 2001 From: ferdymercury Date: Wed, 14 Oct 2026 10:49:41 +0200 Subject: [PATCH 6/6] [ci] do not override to Release --- .github/workflows/root-ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/root-ci.yml b/.github/workflows/root-ci.yml index f362b1c8a58be..e192c6b5eae9e 100644 --- a/.github/workflows/root-ci.yml +++ b/.github/workflows/root-ci.yml @@ -415,7 +415,6 @@ jobs: - image: debian13 overrides: ["dev=ON", "CMAKE_CXX_FLAGS=-Wsuggest-override"] - image: debiantesting - overrides: ["CMAKE_BUILD_TYPE=Release"] # Special builds - image: alma9 platform_config: alma9-modules_off