Skip to content

Requests with ExecuteJavascriptMiddleware are sent twice #239

Description

@fadarrizz

Describe the bug
When using the ExecuteJavascriptMiddleware, two requests are sent. One by Browsershot, the other by Guzzle.

Reproduction
My spider only has the ExecuteJavascriptMiddleware registered as downloader middleware.

I placed dumps with the request object id in the following places, just before requests are sent:

RoachPHP\Http\Client
image
RoachPHP\Downloader\Middleware\ExecuteJavascriptMiddleware
image

When the spider runs, both dumps are shown:
image

Expected behavior
I was expecting only one request being sent: one from Browsershot, not also one from Guzzle.

Package versions (please complete the following information):

  • core: v3.0.1

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions