fix: improve multi-group robustness to prevent bot crashes

- Remove RuntimeError in dm.py when all unrestriction attempts fail,
  replace with error log and friendly user message
- Add try/except around get_user_status() in dm.py membership scan so
  one inaccessible group doesn't abort the entire DM handler
- Add per-group try/except in verify_user() so a failure in one group
  doesn't prevent verification in other groups
- Make get_group_config_for_update() resilient to uninitialized registry
  by catching RuntimeError and returning None
- Fix ruff lint: remove unused imports and variables

Author: rezhajulio

src/bot/group_config.py

@@ -201,7 +201,11 @@ def get_group_config_for_update(update: Update) -> GroupConfig | None:
     """
     if not update.effective_chat:
         return None
-    return get_group_registry().get(update.effective_chat.id)
+    try:
+        return get_group_registry().get(update.effective_chat.id)
+    except RuntimeError:
+        logger.error("Group registry not initialized; skipping update")
+        return None
 
 
 # Module-level singleton

src/bot/handlers/anti_spam.py

@@ -215,7 +215,6 @@ async def handle_new_user_spam(
         return
 
     group_config = get_group_config_for_update(update)
-    chat = update.effective_chat
     user = update.message.from_user
 
     # Only process messages from monitored groups

src/bot/handlers/check.py

@@ -13,7 +13,6 @@
 from telegram.error import TimedOut
 from telegram.ext import ContextTypes
 
-from bot.config import get_settings
 from bot.constants import (
     ADMIN_CHECK_ACTION_COMPLETE,
     ADMIN_CHECK_ACTION_INCOMPLETE,
@@ -248,7 +247,6 @@ async def handle_warn_callback(
         missing_items.append("username")
     missing_text = MISSING_ITEMS_SEPARATOR.join(missing_items) if missing_items else "profil"
 
-    settings = get_settings()
     registry = get_group_registry()
 
     try:

src/bot/handlers/dm.py

@@ -71,7 +71,14 @@ async def handle_dm(update: Update, context: ContextTypes.DEFAULT_TYPE) -> None:
     member_groups = []
     for gc in registry.all_groups():
         logger.info(f"Checking user status in group_id={gc.group_id} for user_id={user.id}")
-        user_status = await get_user_status(context.bot, gc.group_id, user.id)
+        try:
+            user_status = await get_user_status(context.bot, gc.group_id, user.id)
+        except Exception:
+            logger.warning(
+                f"Failed to check user status in group {gc.group_id} for user {user.id}",
+                exc_info=True,
+            )
+            continue
         if user_status is not None and user_status not in (ChatMemberStatus.LEFT, ChatMemberStatus.BANNED):
             member_groups.append((gc, user_status))
 
@@ -174,6 +181,7 @@ async def handle_dm(update: Update, context: ContextTypes.DEFAULT_TYPE) -> None:
         await update.message.reply_text(DM_ALREADY_UNRESTRICTED_MESSAGE)
     else:
         # All unrestriction attempts failed
-        raise RuntimeError(
-            f"Failed to unrestrict user {user.id} in any group"
+        logger.error(f"Failed to unrestrict user {user.id} in any group")
+        await update.message.reply_text(
+            "❌ Gagal membuka pembatasan. Silakan hubungi admin grup."
         )

src/bot/handlers/verify.py

@@ -51,35 +51,42 @@ async def verify_user(
     # Unrestrict user and delete warnings in all monitored groups
     total_deleted = 0
     for group_config in registry.all_groups():
-        # Unrestrict user if they are restricted
         try:
-            await unrestrict_user(bot, group_config.group_id, target_user_id)
-            logger.info(f"Unrestricted user {target_user_id} in group {group_config.group_id} during verification")
-        except BadRequest as e:
-            # User might not be restricted or not in group - that's okay
-            logger.info(f"Could not unrestrict user {target_user_id} in group {group_config.group_id}: {e}")
-
-        # Delete all warning records for this user in this group
-        deleted_count = db.delete_user_warnings(target_user_id, group_config.group_id)
-        total_deleted += deleted_count
-
-        # Send notification to warning topic if user had previous warnings
-        if deleted_count > 0:
-            # Get user info for proper mention
-            user_info = await bot.get_chat(target_user_id)
-            user_mention = get_user_mention(user_info)
-
-            # Send clearance message to warning topic
-            clearance_message = VERIFICATION_CLEARANCE_MESSAGE.format(
-                user_mention=user_mention
+            # Unrestrict user if they are restricted
+            try:
+                await unrestrict_user(bot, group_config.group_id, target_user_id)
+                logger.info(f"Unrestricted user {target_user_id} in group {group_config.group_id} during verification")
+            except BadRequest as e:
+                # User might not be restricted or not in group - that's okay
+                logger.info(f"Could not unrestrict user {target_user_id} in group {group_config.group_id}: {e}")
+
+            # Delete all warning records for this user in this group
+            deleted_count = db.delete_user_warnings(target_user_id, group_config.group_id)
+            total_deleted += deleted_count
+
+            # Send notification to warning topic if user had previous warnings
+            if deleted_count > 0:
+                # Get user info for proper mention
+                user_info = await bot.get_chat(target_user_id)
+                user_mention = get_user_mention(user_info)
+
+                # Send clearance message to warning topic
+                clearance_message = VERIFICATION_CLEARANCE_MESSAGE.format(
+                    user_mention=user_mention
+                )
+                await bot.send_message(
+                    chat_id=group_config.group_id,
+                    message_thread_id=group_config.warning_topic_id,
+                    text=clearance_message,
+                    parse_mode="Markdown"
+                )
+                logger.info(f"Sent clearance notification to warning topic for user {target_user_id} in group {group_config.group_id}")
+        except Exception:
+            logger.warning(
+                f"Verification failed for group {group_config.group_id} for user {target_user_id}",
+                exc_info=True,
             )
-            await bot.send_message(
-                chat_id=group_config.group_id,
-                message_thread_id=group_config.warning_topic_id,
-                text=clearance_message,
-                parse_mode="Markdown"
-            )
-            logger.info(f"Sent clearance notification to warning topic for user {target_user_id} in group {group_config.group_id}")
+            continue
 
     if total_deleted > 0:
         logger.info(f"Deleted {total_deleted} total warning record(s) for user {target_user_id}")

tests/test_check.py

@@ -416,7 +416,6 @@ async def test_warn_callback_success(
         mock_context.bot.get_chat.return_value = mock_chat
 
         with (
-            patch("bot.handlers.check.get_settings", return_value=mock_settings),
             patch(
                 "bot.handlers.check.get_group_registry",
                 return_value=mock_registry,
@@ -459,7 +458,6 @@ async def test_warn_callback_success_missing_photo_only(
         mock_context.bot.get_chat.return_value = mock_chat
 
         with (
-            patch("bot.handlers.check.get_settings", return_value=mock_settings),
             patch(
                 "bot.handlers.check.get_group_registry",
                 return_value=mock_registry,
@@ -534,7 +532,6 @@ async def test_warn_callback_send_message_error(
         mock_context.bot.send_message.side_effect = Exception("Failed to send")
 
         with (
-            patch("bot.handlers.check.get_settings", return_value=mock_settings),
             patch(
                 "bot.handlers.check.get_group_registry",
                 return_value=mock_registry,
@@ -566,7 +563,6 @@ async def test_warn_callback_timeout(
         mock_context.bot.send_message.side_effect = TimedOut()
 
         with (
-            patch("bot.handlers.check.get_settings", return_value=mock_settings),
             patch(
                 "bot.handlers.check.get_group_registry",
                 return_value=mock_registry,
@@ -597,7 +593,6 @@ async def test_warn_callback_get_chat_timeout(
         mock_context.bot.get_chat.side_effect = TimedOut()
 
         with (
-            patch("bot.handlers.check.get_settings", return_value=mock_settings),
             patch(
                 "bot.handlers.check.get_group_registry",
                 return_value=mock_registry,

tests/test_dm_handler.py

@@ -460,5 +460,7 @@ async def test_unrestrict_user_exception_logged_and_raised(
                 side_effect=Exception("test error"),
             ),
         ):
-            with pytest.raises(RuntimeError, match="Failed to unrestrict user 12345 in any group"):
-                await handle_dm(mock_update, mock_context)
+            await handle_dm(mock_update, mock_context)
+            mock_update.message.reply_text.assert_called_with(
+                "❌ Gagal membuka pembatasan. Silakan hubungi admin grup."
+            )

tests/test_group_config.py

@@ -3,7 +3,6 @@
 import json
 import tempfile
 from datetime import timedelta
-from pathlib import Path
 from unittest.mock import MagicMock, patch
 
 import pytest