From bd58ddb9b0b3e1cd3026b0a462cfd69640f29ee5 Mon Sep 17 00:00:00 2001 From: mikaello <2505178+mikaello@users.noreply.github.com> Date: Wed, 22 Apr 2026 20:14:52 +0200 Subject: [PATCH 1/5] docs: fix wrong function names in List doc comments - fromInitializer was documented as makeBy - reduceReverse2 was documented as reduce2 in its own doc comment --- src/Core__List.resi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Core__List.resi b/src/Core__List.resi index 610a2820..3ac1fcb9 100644 --- a/src/Core__List.resi +++ b/src/Core__List.resi @@ -179,7 +179,7 @@ List.make(~length=3, 1) // list{1, 1, 1} let make: (~length: int, 'a) => t<'a> /** -`makeBy(length, f)` return a list of length `length` with element initialized +`fromInitializer(~length, f)` return a list of length `length` with element initialized with `f`. Returns an empty list if `length` is negative. ## Examples @@ -534,7 +534,7 @@ let reduce2: (t<'b>, t<'c>, 'a, ('a, 'b, 'c) => 'a) => 'a `reduceReverse2(list1, list2, initialValue, f)` applies `f` to each element of `list1` and `list2`from end to beginning. Stops with the shorter list. Function `f` has three parameters: an accumulator which starts with a value of -`initialValue`, an item from `l1`, and an item from `l2`. `reduce2` returns the +`initialValue`, an item from `l1`, and an item from `l2`. `reduceReverse2` returns the final value of the accumulator. ## Examples From eac9796965ef5724dd9267d79fd621feb48ccb74 Mon Sep 17 00:00:00 2001 From: mikaello <2505178+mikaello@users.noreply.github.com> Date: Wed, 22 Apr 2026 20:14:58 +0200 Subject: [PATCH 2/5] docs: fix all6 and allSettled6 doc comments - p3 was missing from parameter list (had p1, p2, p4, p5, p6) - malformed comment closing ")*/" fixed to "*/" --- src/Core__Promise.resi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Core__Promise.resi b/src/Core__Promise.resi index 5468bf93..82a2a1c7 100644 --- a/src/Core__Promise.resi +++ b/src/Core__Promise.resi @@ -341,8 +341,8 @@ external all4: ((t<'a>, t<'b>, t<'c>, t<'d>)) => t<('a, 'b, 'c, 'd)> = "all" external all5: ((t<'a>, t<'b>, t<'c>, t<'d>, t<'e>)) => t<('a, 'b, 'c, 'd, 'e)> = "all" /** -`all6((p1, p2, p4, p5, p6))`. Like `all()`, but with a fixed size tuple of 6 -")*/ +`all6((p1, p2, p3, p4, p5, p6))`. Like `all()`, but with a fixed size tuple of 6 +*/ @scope("Promise") @val external all6: ((t<'a>, t<'b>, t<'c>, t<'d>, t<'e>, t<'f>)) => t<('a, 'b, 'c, 'd, 'e, 'f)> = "all" @@ -425,8 +425,8 @@ external allSettled5: ((t<'a>, t<'b>, t<'c>, t<'d>, t<'e>)) => t<( )> = "allSettled" /** -`allSettled6((p1, p2, p4, p5, p6))`. Like `allSettled()`, but with a fixed size tuple of 6 -")*/ +`allSettled6((p1, p2, p3, p4, p5, p6))`. Like `allSettled()`, but with a fixed size tuple of 6 +*/ @scope("Promise") @val external allSettled6: ((t<'a>, t<'b>, t<'c>, t<'d>, t<'e>, t<'f>)) => t<( From 774a88a57a571d9bd0a50a44c723ee96c159c678 Mon Sep 17 00:00:00 2001 From: mikaello <2505178+mikaello@users.noreply.github.com> Date: Wed, 22 Apr 2026 20:15:09 +0200 Subject: [PATCH 3/5] docs: fix maxValue example showing minValue instead --- src/Core__Float.resi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Core__Float.resi b/src/Core__Float.resi index 806d8df9..a81ee89c 100644 --- a/src/Core__Float.resi +++ b/src/Core__Float.resi @@ -102,7 +102,7 @@ module Constants: { ## Examples ```rescript - Float.Constants.minValue + Float.Constants.maxValue ``` */ @val From b03689cae5a60f3ffd43dfc203e0c475d03b25cf Mon Sep 17 00:00:00 2001 From: mikaello <2505178+mikaello@users.noreply.github.com> Date: Wed, 22 Apr 2026 21:32:32 +0200 Subject: [PATCH 4/5] docs: fix RegExp.sticky example calling unicode, and unicode flag label --- src/Core__RegExp.resi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Core__RegExp.resi b/src/Core__RegExp.resi index 3e12daef..9b1c12a1 100644 --- a/src/Core__RegExp.resi +++ b/src/Core__RegExp.resi @@ -263,17 +263,17 @@ See [`RegExp.sticky`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Re ## Examples ```rescript let regexp1 = RegExp.fromStringWithFlags("\\w+", ~flags="g") -Console.log(regexp1->RegExp.unicode) // Logs `false`, since `y` is not set +Console.log(regexp1->RegExp.sticky) // Logs `false`, since `y` is not set let regexp2 = RegExp.fromStringWithFlags("\\w+", ~flags="my") -Console.log(regexp2->RegExp.unicode) // Logs `true`, since `y` is set +Console.log(regexp2->RegExp.sticky) // Logs `true`, since `y` is set ``` */ @get external sticky: t => bool = "sticky" /** -`unicode(regexp)` returns whether the unicode (`y`) flag is set on this `RegExp`. +`unicode(regexp)` returns whether the unicode (`u`) flag is set on this `RegExp`. See [`RegExp.unicode`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/unicode) on MDN. From 5083298418752fbd56172af39e18dd4c8517f646 Mon Sep 17 00:00:00 2001 From: mikaello <2505178+mikaello@users.noreply.github.com> Date: Wed, 22 Apr 2026 21:32:32 +0200 Subject: [PATCH 5/5] docs: fix typo cc -> c in List.forEachWithIndex example --- src/Core__List.resi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Core__List.resi b/src/Core__List.resi index 3ac1fcb9..a013cc04 100644 --- a/src/Core__List.resi +++ b/src/Core__List.resi @@ -432,7 +432,7 @@ List.forEachWithIndex(list{"a", "b", "c"}, (x, index) => { prints: Item 0 is a Item 1 is b - Item 2 is cc + Item 2 is c */ ``` */